Trigger only fires once, why?

I need this trigger to fire multiple times but it is only firing once. Can someone tell me why? What do I need to change to make this trigger fire more than once?

You're killing the rifleman twice, for one thing. That might be crashing your thread.

(Killing all riflemen). You're also removing a single picked unit, (dunno if that would even work since it's outside of an enum call), "Kill (Triggering Unit)" is not needed since the triggering unit must be a rifleman and you already kill all of them.

Also, why not shift those conditions for the If/Then directly into the conditions section?

Can you explain how you came to this conclusion? The trigger looks to kill all the riflemen only once.

That's what my first thoughts were to. But, if I left it out it would actually take 10 riflemen to make the trigger kill them all and it would leave the 10th rifleman alive.

Because I don't want to write a trigger for every unit I want to do this to. 10 riflemen change to a marine, 10 marines change to a fel space orc, 10 fel space orcs change to a Hydralisk.....So instead of writing 3 triggers for 10 players I can just write one for one :)

Simple.

Unit type HAS to be a rifleman, right?
So:
The triggering unit (the unit who entered) is now in P1Upgrade, right? So, that would be 9 riflemen, since your trigger checks for 9. Otherwise, it wouldn't work (9 + 1 = 10, no?)

You then pick every unit in P1Upgrade which INCLUDES the triggering unit, because he has to be in P1Upgrade for the trigger to fire. You then kill all the riflemen. And for the record, I really don't think Remove (Picked Unit) works, since it's outside of a Unit-Group loop.

Afterwards, you proceed to kill the triggering unit who already should've been killed because he was in P1Upgrade when all the riflemen were picked and killed.


Make sense?

Another way to put it:

There's 8 riflemen in P1Upgrade. The ninth enters, triggering the actions. So now there are 9 riflemen. You kill all the riflemen in P1Upgrade, which is 9. 9 - 9 = 0.

You then remove the picked unit. Which doesn't work. But if it did somehow, that'd be 0 - 1. -1. You can't have -1 units.

If that doesn't work, you till have 0 units. You then proceed to kill the trigger unit. Which is 0 - 1 = -1.
You can't kill a unit that's already dead. And if you were trying to remove all those riflemen, killing one could cause problems since the "Triggering Unit" would be an empty handle.

yes

No, the triggering unit doesn't get moved. He is supposed to die when 8 other riflemen get to the location.


For some reason he doesn't die and isn't included. I will triple check it though.Edited because: Yep, in order for the trigger to kill 9 riflemen I need 9+1 to do it.

I saw a trigger in the forums using that type a few months back and thought it was considered a leak if you picked units and didn't remove them (even though they are killed). Guess I can should remove it if thats not the case.

What the heck? You make 0 sense. Your trigger fires when a UNIT ENTERS P1Upgrade. It then CHECKS that there are 9 units there, which would have to include the entering unit since he's in that region! Unless my logic fails me, would it not make sense that a unit who triggers a UNIT ENTERS [region] event is IN the region he entered, and thus available for checking?

Then something must be wrong with how you're doing it, because either A) This makes no sense or B) You aren't explaining how this works, so I'm telling you things that have no value as to how the trigger is SUPPOSED to work.

Uhhh... No. And you "method" wouldn't work anyways. It would be trying to remove a "null" unit, since "Picked Unit" would return null outside of a group loop.

I can't explain why its doing what its doing. Maybe I can explain what I want the trigger to do.

if 9 units enter p1upgrade
if all of those 9 units are riflemen
kill all riflemen
create 1 marine at Player 1 USpawn
Then I want to repeat if for as many times as I need.

The trigger that I used above is copy/pasted so there are no typo's. What actually happens is this.

I bring 9 riflemen to p1upgrade (nothing happens)
I bring 1 more riflemen to p1upgrade (9 riflemen die and the 10th is left there and the marine is created at Player 1 USpawn)
And to top it off, it only works once.

There is a bug, that sometimes the unit which triggers the "Unit-Enters Region" Event isn't really inside the region:
http://www.wc3campaigns.net/showthread.php?t=61918

And as darkwulfvsaid: The Remove Picked Unit-thing doesn't work outside a pick every unit-loop, just replace Kill Picked Unit with Remove Picked Unit.

I think you just have to remove all the units from the unit group to prevent leaks, you don't have to remove that unit from the game.

Ok, the remove unit fixed the issue with it only firing once. I still have the other problem.

When Unit- Kill (Triggering Unit) is disabled I actually need 9+1 for the trigger to fire everytime. When I enable Unit - Kill (triggering unit) I need 9+1 for the first time only. After the first time it works like it should. If I replace Unit - Kill (Triggering Unit) with Unit - Remove (triggering unit) I need 9+1 everytime.

It's ok if I want 9 riflemen to die that I can just set the trigger to check for 8 (since the trigger appears to be meeting all the conditions and THEN waiting for the event). My next question is, will it have a negative effect on my map? I will be using several different -If (All Conditions are True) then do (Then Actions) else do (Else Actions)- for this trigger and all 8 players will be able to do it and they will need to be doing it quite frequently.

You are right, but first I have to put them in a temp unit group. I was under the impression that when you used unit group - pick ever unit that it automatically placed the picked units in a temp group (kinda like a hidden variable) but thats not the case.

I think I am just going to try to set them all in a temp group then destroy the group. This may be the reason why the triggering unit doesn't get picked. Using Unit Group - Pick every unit does in fact cause leaks if you do not set them to a unit group.