A question about string leaks + submission rules

12-05-2008, 11:10 AM

I think strings might leak, but I can only find very few threads covering that. Please tell me anything about it if you know.

BTW,

Quote:

Originally Posted by Resource Submission Rules

Memory Leaks
Your submission must have no memory leaks. If you are unsure about what memory leaks are and how to avoid them, find out more in the tutorial section.

If there is a string leak in a submission, is it considered against this rule? I haven't seen someone talking about that either.

Edit:

Scripts/Blizzard.j:

function OrderId2StringBJ takes integer orderId returns string
    local string orderString

    // Check to see if it's a generic order.
    set orderString = OrderId2String(orderId)
    if (orderString != null) then
        return orderString
    endif

    // Check to see if it's a (train) unit order.
    set orderString = UnitId2String(orderId)
    if (orderString != null) then
        return orderString
    endif

    // Unrecognized - return an empty string.
    return ""
endfunction

To be more specific, I was actually trying to use above function in a library I am currently making. Is this BJ function okay to use?

12-05-2008, 12:08 PM	#2
Captain Griffen	String 'leaks' are not leaks. They are cached. In 99.9% of cases, don't worry. Only if you're creating thousands of them should you even consider it (primarily in save codes).