My unkillability ( =/= invulnerability) system doesnt work 100%, why?!

I basically made a system unallowing heroes to be killed by non-hero units.
It would leave them down to 1 hp but any damage dealt to them would be pro-actively prevented.

When a hero would deal any damage to the almost dead hero, though, a trigger called Death Scene would fire and make a small cutscene where the killer hero finishes the agonizing one.


However when i finished it (it actually works), i noticed that sometimes (quite randomly), it would let a random hero (usually the first time it is supposed to fire) die without doing its anti-death job. No Death Scene would occur, it would be just like the system never existed.

I already found one part of the solution: this system cannot handle damage higher than the hero's hp. That because the hero cannot be healed higher than his max hp, then when the damage is applied he is instakilled anyways.
Still, sometimes, a very low damage from a random unit/hero kills a hero while it should not.


If you guys have any idea why it doesnt work, or if you could provide a workaround, i would be grateful. Credit would be given ingame of course.
Here is the system:

Initialization: indexing the anti-death triggers:

Setting up the system: assigning each hero to a trigger:

One of the to-be-indexed antideath triggers (they are all copy-pastes):

The Death Scene trigger, supposed to be the only way a hero can die:
(there is no event because it is fired straight from the antideath triggers, using 2 globals.)

Use GUI tags.

Change condition on damaged trigger to be life < damage taken + 1; should fix it. If a unit's health goes below 0.405, then it dies - it doesn't have to go to zero.

Thx for the quick feedback, testing this solution rightaway.
i will learn to use GUI tags, too.

By the way could this system be responsible for a sudden increase in lag? (from one version of the map without it, to one with it?)

EDIT: Actually, is this system efficient or could it be improved in any way (no talking about jassing it, there)?

You will probably get more feedback after you convert it to GUI tags, I don't want to read it with those screenshots.

Omg... i just tried using GUI tags, the only way i found is to manually right click every single line and "copy as text" then paste it here between both tags...

This is such a Pain >.< it's gonna take me half an hour to paste the amount of lines i have in those triggers :/ i'm sure there must be another way, could you guys please teach me?

Just right click on the trigger title and select copy as text. That will copy the whole trigger.

right click the trigger name in the event/cond/actions window. it copies the whole trigger into text.

Okay thanks for the GUI tags tuto guys, i have fixed the display now, and added the roles of each trigger.
So, any idea?

Well the only part of those triggers relevant to your question seems to be the part where you increase the unit's life if they would have died from the damage taken. These are two possible problems (other than the one you noticed about units dying in one hit):

1.) You should follow Griffen's advice and consider the fact that units die if their HP goes below 0.405, not below 0. So your condition needs to be "if unit life - 0.405 >= damage" (this is probably your main problem)

2.) If two units damage the same unit at exactly the same time (more common than you might think if you have lots of units on the map), and the sum of their damage is enough to kill the damaged unit in one hit, this method won't save it from dying

Let me ask you this, are you completely allergic to using custom script calls or libraries?

First of all: i've tried Griffen's system, and in the last test i ran, with thousands of instances of the antideath triggers firing, none of the heroes died to a non-hero unit!!

I found some other bugs though, so ill fix them and retest to see if it's Really actually working.


@grim: Actually I just don't have any clue about libraries, but I have nothing against custom scripts. I have made a couple jass spells/mechanisms in this map aswell btw.

Why would i use a custom script in this trigger btw? could it improve anything? I don't think it leaks, i mean.

EDIT: Also, any idea if there is a fix for this case: "the hero is dealt damage higher than his max hp." ?
I thought about making him invulnerable and running a timer expiring in 0.00 or 0.01 seconds that removes the invul, any better idea?

Add an ability giving it a load more HP, then have a 0. second timer and then remove it.

If it were that simple, Griffen, DamageMod wouldn't need to exist.

Dj0z, you're trying to do something that is actually quite complicated to pull off correctly. If you just add some max life to the unit it will probably work "most of the time," but you'll still get the random errors, especially if two units attack at the exact same time.

Anyway there is no point in explaining to you how to reinvent the wheel, this is exactly what I created DamageMod for. I would suggest you use it. It will just take a very simple custom script call to modify the incoming damage by the correct amount to leave the damaged unit with 1 HP.

There is no such thing possible as "attacking at the exact same time." Simply that cannot happen. All in-game events are processed sequentially.
However, involvement of timer can cause an issue. In that particular case, insufficient logic may cause some trouble since execution order is not guaranteed. While attacks cannot be at the exact same time, but they can happen in a single frame.

Added: As the event fires before actual damage is applied, I think there still is possibility of conflict. I think you can solve that by saving the amount of adjusted life to a unit, comparing it with unit's current life, and accumulate it if necessary. Whether there is possible conflict and needs to be solved can only be determined by further testing (means I'm not sure that may happen).

You're wrong. There's a minimum granularity to the attack intervals in WC3. Test it yourself.

Ye, grim is correct

Is how "EvasionMod" works