Help shortening a trigger

Hidden information: Trigger: Maiden Upgrade Events Unit - A unit Acquires an item Conditions (Unit-type of (Triggering unit)) Equal to Maiden Or - Any (Conditions) are true Conditions (Item-type of (Item being manipulated)) Equal to Rusted Sword (Item-type of (Item being manipulated)) Equal to Rusted Shield (Item-type of (Item being manipulated)) Equal to Rusted Armor (Item-type of (Item being manipulated)) Equal to Wooden Bow (Item-type of (Item being manipulated)) Equal to Rusted Arrows (Item-type of (Item being manipulated)) Equal to Patched Cape (Item-type of (Item being manipulated)) Equal to Patched Robe (Item-type of (Item being manipulated)) Equal to Rusted Circlet (Item-type of (Item being manipulated)) Equal to Rusted Ring Actions If (All Conditions are True) then do (Then Actions) else do (Else Actions) If - Conditions Or - Any (Conditions) are true Conditions Rusted Sword Equal to (Item-type of (Item being manipulated)) Rusted Shield Equal to (Item-type of (Item being manipulated)) Rusted Armor Equal to (Item-type of (Item being manipulated)) And - All (Conditions) are true Conditions ((Item carried by (Triggering unit) of type Rusted Sword) is owned) Equal to True ((Item carried by (Triggering unit) of type Rusted Shield) is owned) Equal to True ((Item carried by (Triggering unit) of type Rusted Armor) is owned) Equal to True Then - Actions Set Integer_ReferenceX = 1 If (All Conditions are True) then do (Then Actions) else do (Else Actions) If - Conditions (Item-type of (Item carried by (Triggering unit) in slot Integer_ReferenceX)) Not equal to Rusted Sword (Item-type of (Item carried by (Triggering unit) in slot Integer_ReferenceX)) Not equal to Rusted Shield (Item-type of (Item carried by (Triggering unit) in slot Integer_ReferenceX)) Not equal to Rusted Armor Then - Actions Hero - Drop the item from slot Integer_ReferenceX of (Triggering unit) Else - Actions Set Integer_ReferenceX = 2 If (All Conditions are True) then do (Then Actions) else do (Else Actions) If - Conditions (Item-type of (Item carried by (Triggering unit) in slot Integer_ReferenceX)) Not equal to Rusted Sword (Item-type of (Item carried by (Triggering unit) in slot Integer_ReferenceX)) Not equal to Rusted Shield (Item-type of (Item carried by (Triggering unit) in slot Integer_ReferenceX)) Not equal to Rusted Armor Then - Actions Hero - Drop the item from slot Integer_ReferenceX of (Triggering unit) Else - Actions Set Integer_ReferenceX = 3 If (All Conditions are True) then do (Then Actions) else do (Else Actions) If - Conditions (Item-type of (Item carried by (Triggering unit) in slot Integer_ReferenceX)) Not equal to Rusted Sword (Item-type of (Item carried by (Triggering unit) in slot Integer_ReferenceX)) Not equal to Rusted Shield (Item-type of (Item carried by (Triggering unit) in slot Integer_ReferenceX)) Not equal to Rusted Armor Then - Actions Hero - Drop the item from slot Integer_ReferenceX of (Triggering unit) Else - Actions Set Integer_ReferenceX = 4 If (All Conditions are True) then do (Then Actions) else do (Else Actions) If - Conditions (Item-type of (Item carried by (Triggering unit) in slot Integer_ReferenceX)) Not equal to Rusted Sword (Item-type of (Item carried by (Triggering unit) in slot Integer_ReferenceX)) Not equal to Rusted Shield (Item-type of (Item carried by (Triggering unit) in slot Integer_ReferenceX)) Not equal to Rusted Armor Then - Actions Hero - Drop the item from slot Integer_ReferenceX of (Triggering unit) Else - Actions Set Integer_ReferenceX = 5 If (All Conditions are True) then do (Then Actions) else do (Else Actions) If - Conditions (Item-type of (Item carried by (Triggering unit) in slot Integer_ReferenceX)) Not equal to Rusted Sword (Item-type of (Item carried by (Triggering unit) in slot Integer_ReferenceX)) Not equal to Rusted Shield (Item-type of (Item carried by (Triggering unit) in slot Integer_ReferenceX)) Not equal to Rusted Armor Then - Actions Hero - Drop the item from slot Integer_ReferenceX of (Triggering unit) Else - Actions Set Integer_ReferenceX = 6 If (All Conditions are True) then do (Then Actions) else do (Else Actions) If - Conditions (Item-type of (Item carried by (Triggering unit) in slot Integer_ReferenceX)) Not equal to Rusted Sword (Item-type of (Item carried by (Triggering unit) in slot Integer_ReferenceX)) Not equal to Rusted Shield (Item-type of (Item carried by (Triggering unit) in slot Integer_ReferenceX)) Not equal to Rusted Armor Then - Actions Hero - Drop the item from slot Integer_ReferenceX of (Triggering unit) Else - Actions Set TempPoint = (Position of (Triggering unit)) Set Player_ReferenceX = (Owner of (Triggering unit)) Set Real_ReferenceX = (Facing of (Triggering unit)) Unit - Remove (Triggering unit) from the game Unit - Create 1 Gladiatrix for Player_ReferenceX at TempPoint facing Real_ReferenceX degrees Custom script: call RemoveLocation (udg_TempPoint) Set Unit_ReferenceX = (Last created unit) Special Effect - Create a special effect attached to the origin of Unit_ReferenceX using Abilities\Spells\Other\Levelup\LevelupCaster.mdl Special Effect - Destroy (Last created special effect) Else - Actions If (All Conditions are True) then do (Then Actions) else do (Else Actions) If - Conditions Or - Any (Conditions) are true Conditions Wooden Bow Equal to (Item-type of (Item being manipulated)) Rusted Arrows Equal to (Item-type of (Item being manipulated)) Patched Cape Equal to (Item-type of (Item being manipulated)) And - All (Conditions) are true Conditions ((Item carried by (Triggering unit) of type Wooden Bow) is owned) Equal to True ((Item carried by (Triggering unit) of type Rusted Arrows) is owned) Equal to True ((Item carried by (Triggering unit) of type Patched Cape) is owned) Equal to True Then - Actions Set Integer_ReferenceX = 1 If (All Conditions are True) then do (Then Actions) else do (Else Actions) If - Conditions (Item-type of (Item carried by (Triggering unit) in slot Integer_ReferenceX)) Not equal to Wooden Bow (Item-type of (Item carried by (Triggering unit) in slot Integer_ReferenceX)) Not equal to Rusted Arrows (Item-type of (Item carried by (Triggering unit) in slot Integer_ReferenceX)) Not equal to Patched Cape Then - Actions Hero - Drop the item from slot Integer_ReferenceX of (Triggering unit) Else - Actions Set Integer_ReferenceX = 2 If (All Conditions are True) then do (Then Actions) else do (Else Actions) If - Conditions (Item-type of (Item carried by (Triggering unit) in slot Integer_ReferenceX)) Not equal to Wooden Bow (Item-type of (Item carried by (Triggering unit) in slot Integer_ReferenceX)) Not equal to Rusted Arrows (Item-type of (Item carried by (Triggering unit) in slot Integer_ReferenceX)) Not equal to Patched Cape Then - Actions Hero - Drop the item from slot Integer_ReferenceX of (Triggering unit) Else - Actions Set Integer_ReferenceX = 3 If (All Conditions are True) then do (Then Actions) else do (Else Actions) If - Conditions (Item-type of (Item carried by (Triggering unit) in slot Integer_ReferenceX)) Not equal to Wooden Bow (Item-type of (Item carried by (Triggering unit) in slot Integer_ReferenceX)) Not equal to Rusted Arrows (Item-type of (Item carried by (Triggering unit) in slot Integer_ReferenceX)) Not equal to Patched Cape Then - Actions Hero - Drop the item from slot Integer_ReferenceX of (Triggering unit) Else - Actions Set Integer_ReferenceX = 4 If (All Conditions are True) then do (Then Actions) else do (Else Actions) If - Conditions (Item-type of (Item carried by (Triggering unit) in slot Integer_ReferenceX)) Not equal to Wooden Bow (Item-type of (Item carried by (Triggering unit) in slot Integer_ReferenceX)) Not equal to Rusted Arrows (Item-type of (Item carried by (Triggering unit) in slot Integer_ReferenceX)) Not equal to Patched Cape Then - Actions Hero - Drop the item from slot Integer_ReferenceX of (Triggering unit) Else - Actions Set Integer_ReferenceX = 5 If (All Conditions are True) then do (Then Actions) else do (Else Actions) If - Conditions (Item-type of (Item carried by (Triggering unit) in slot Integer_ReferenceX)) Not equal to Wooden Bow (Item-type of (Item carried by (Triggering unit) in slot Integer_ReferenceX)) Not equal to Rusted Arrows (Item-type of (Item carried by (Triggering unit) in slot Integer_ReferenceX)) Not equal to Patched Cape Then - Actions Hero - Drop the item from slot Integer_ReferenceX of (Triggering unit) Else - Actions Set Integer_ReferenceX = 6 If (All Conditions are True) then do (Then Actions) else do (Else Actions) If - Conditions (Item-type of (Item carried by (Triggering unit) in slot Integer_ReferenceX)) Not equal to Wooden Bow (Item-type of (Item carried by (Triggering unit) in slot Integer_ReferenceX)) Not equal to Rusted Arrows (Item-type of (Item carried by (Triggering unit) in slot Integer_ReferenceX)) Not equal to Patched Cape Then - Actions Hero - Drop the item from slot Integer_ReferenceX of (Triggering unit) Else - Actions Set TempPoint = (Position of (Triggering unit)) Set Player_ReferenceX = (Owner of (Triggering unit)) Set Real_ReferenceX = (Facing of (Triggering unit)) Unit - Remove (Triggering unit) from the game Unit - Create 1 Amazon for Player_ReferenceX at TempPoint facing Real_ReferenceX degrees Custom script: call RemoveLocation (udg_TempPoint) Set Unit_ReferenceX = (Last created unit) Special Effect - Create a special effect attached to the origin of Unit_ReferenceX using Abilities\Spells\Other\Levelup\LevelupCaster.mdl Special Effect - Destroy (Last created special effect) Else - Actions If (All Conditions are True) then do (Then Actions) else do (Else Actions) If - Conditions Or - Any (Conditions) are true Conditions Patched Robe Equal to (Item-type of (Item being manipulated)) Rusted Circlet Equal to (Item-type of (Item being manipulated)) Rusted Ring Equal to (Item-type of (Item being manipulated)) And - All (Conditions) are true Conditions ((Item carried by (Triggering unit) of type Patched Robe) is owned) Equal to True ((Item carried by (Triggering unit) of type Rusted Circlet) is owned) Equal to True ((Item carried by (Triggering unit) of type Rusted Ring) is owned) Equal to True Then - Actions Set Integer_ReferenceX = 1 If (All Conditions are True) then do (Then Actions) else do (Else Actions) If - Conditions (Item-type of (Item carried by (Triggering unit) in slot Integer_ReferenceX)) Not equal to Patched Robe (Item-type of (Item carried by (Triggering unit) in slot Integer_ReferenceX)) Not equal to Rusted Circlet (Item-type of (Item carried by (Triggering unit) in slot Integer_ReferenceX)) Not equal to Rusted Ring Then - Actions Hero - Drop the item from slot Integer_ReferenceX of (Triggering unit) Else - Actions Set Integer_ReferenceX = 2 If (All Conditions are True) then do (Then Actions) else do (Else Actions) If - Conditions (Item-type of (Item carried by (Triggering unit) in slot Integer_ReferenceX)) Not equal to Patched Robe (Item-type of (Item carried by (Triggering unit) in slot Integer_ReferenceX)) Not equal to Rusted Circlet (Item-type of (Item carried by (Triggering unit) in slot Integer_ReferenceX)) Not equal to Rusted Ring Then - Actions Hero - Drop the item from slot Integer_ReferenceX of (Triggering unit) Else - Actions Set Integer_ReferenceX = 3 If (All Conditions are True) then do (Then Actions) else do (Else Actions) If - Conditions (Item-type of (Item carried by (Triggering unit) in slot Integer_ReferenceX)) Not equal to Patched Robe (Item-type of (Item carried by (Triggering unit) in slot Integer_ReferenceX)) Not equal to Rusted Circlet (Item-type of (Item carried by (Triggering unit) in slot Integer_ReferenceX)) Not equal to Rusted Ring Then - Actions Hero - Drop the item from slot Integer_ReferenceX of (Triggering unit) Else - Actions Set Integer_ReferenceX = 4 If (All Conditions are True) then do (Then Actions) else do (Else Actions) If - Conditions (Item-type of (Item carried by (Triggering unit) in slot Integer_ReferenceX)) Not equal to Patched Robe (Item-type of (Item carried by (Triggering unit) in slot Integer_ReferenceX)) Not equal to Rusted Circlet (Item-type of (Item carried by (Triggering unit) in slot Integer_ReferenceX)) Not equal to Rusted Ring Then - Actions Hero - Drop the item from slot Integer_ReferenceX of (Triggering unit) Else - Actions Set Integer_ReferenceX = 5 If (All Conditions are True) then do (Then Actions) else do (Else Actions) If - Conditions (Item-type of (Item carried by (Triggering unit) in slot Integer_ReferenceX)) Not equal to Patched Robe (Item-type of (Item carried by (Triggering unit) in slot Integer_ReferenceX)) Not equal to Rusted Circlet (Item-type of (Item carried by (Triggering unit) in slot Integer_ReferenceX)) Not equal to Rusted Ring Then - Actions Hero - Drop the item from slot Integer_ReferenceX of (Triggering unit) Else - Actions Set Integer_ReferenceX = 6 If (All Conditions are True) then do (Then Actions) else do (Else Actions) If - Conditions (Item-type of (Item carried by (Triggering unit) in slot Integer_ReferenceX)) Not equal to Patched Robe (Item-type of (Item carried by (Triggering unit) in slot Integer_ReferenceX)) Not equal to Rusted Circlet (Item-type of (Item carried by (Triggering unit) in slot Integer_ReferenceX)) Not equal to Rusted Ring Then - Actions Hero - Drop the item from slot Integer_ReferenceX of (Triggering unit) Else - Actions Set TempPoint = (Position of (Triggering unit)) Set Player_ReferenceX = (Owner of (Triggering unit)) Set Real_ReferenceX = (Facing of (Triggering unit)) Unit - Remove (Triggering unit) from the game Unit - Create 1 Coquette for Player_ReferenceX at TempPoint facing Real_ReferenceX degrees Custom script: call RemoveLocation (udg_TempPoint) Set Unit_ReferenceX = (Last created unit) Special Effect - Create a special effect attached to the origin of Unit_ReferenceX using Abilities\Spells\Other\Levelup\LevelupCaster.mdl Special Effect - Destroy (Last created special effect) Else - Actions

Hello everyone. Could use a quick amount of help, just for the moment. Nothing real big or urgent, just... yeah.

I'm wondering if there is a way to make this trigger shorter & more concise? I prefer to use only GUI methods.

Basically, the trigger is supposed to transform a unit into one of other three units, depending on what items have been picked up; the trigger also saves miscellaneous items that were not needed, so that during the process items not needed are not permanently lost. I feel there's a more concise way to do it than the way I did, though--even though it seems that my way works properly.

I don't know how to manage GUI fully, so I don't know if there are any shortcuts to what I had just done; however, if there is, I'd like to know. Thanks ahead of time. :D

Too bad, cause this function you wrote here would look beautiful if implemented through a good Jass method, specially with patch 1.24 :( I doubt so much there's a GUI alternative that does not involve you doing something incredibly crazy like a linear loop and it will still look so bad, I also know blizz well enough to know they didn't made it possible to use item types as hashtable keys, so I can't think of a good idea to simplify this using only GUI.

As Vexorian said, linear loops could shorten the code... in GUI, but I guess it'll become slower, longer and very, very crappy when the internal compiler converts it to JASS.

It's better for you to stick with what you've got, unless... not to sound unoriginal, "unless you learn JASS".

Thanks very much nonetheless. Very appreciated. I guess I'll just stick with what I have, and hope I won't have to make any future changes to the trigger... it involved a lot of copying & pasting, ahahahah. xD