Point Leaks

09-23-2010, 01:47 PM	#1
Kino	Basically the trigger action. "Change floating text to position of unit" is the other function besides "change floating text position to point". What I need to know is if the first function I mentioned leaks the point.

09-23-2010, 02:35 PM	#2
Fledermaus	EDIT: Misread. "Change floating text to position of unit" does not leak :)

09-23-2010, 06:50 PM	#3
DioD	why not to check JASS code of this actions?

09-24-2010, 08:52 AM	#4
Kino	Well thats there Fled. As for Diod, dont understand JASS so its not really gonna help :P

09-25-2010, 06:24 AM	#5
Pyrogasm	And Fledermaus is incorrect. "Position of Unit" calls the GetUnitLoc() function which does leak a point. The way to correct this is, of course: Trigger: Actions Set TempPoint = "Position of <Unit>" Floating Text - Change floating text to TempPoint Custom script: call RemoveLocation(udg_TempPoint)

09-25-2010, 07:42 AM

Krysho

Quote:

Originally Posted by Pyrogasm

And Fledermaus is incorrect. "Position of Unit" calls the GetUnitLoc() function which does leak a point. The way to correct this is, of course:

Trigger:

Actions

Set TempPoint = "Position of <Unit>"

Floating Text - Change floating text to TempPoint

Custom script: call RemoveLocation(udg_TempPoint)

JASS:

native SetTextTagPos                takes texttag t, real x, real y, real heightOffset returns nothing
native SetTextTagPosUnit            takes texttag t, unit whichUnit, real heightOffset returns nothing

Ultimately it depends on whether the former or the latter is what ends up being used.

The first post mentions that there are two choices for setting the position of a texttag, to the "position of unit" or to a point's position. Most likely these are corresponding to the two available GUI actions "Change Position to Unit" and "Change Position to Point".

Since the thread starter is apparently asking about the former GUI function, this would correspond to the latter JASS function above, which is a native that does not take in a location.

From the looks of it, you might have misinterpreted the same way Fledermaus might have.

09-25-2010, 01:02 PM

Fledermaus

Yeah I read it like that first too.

It's confusing because he copied the GUI function name wrong (I assume). Since he refers to it as "the other function", on my second reading I figured he meant "Floating Text - Change Position to Unit". I probably should have put that in my post though..

So to recap, ""Floating Text - Change Position to Point" will leak the point (you can prevent that with the method Pyro showed) and "Floating Text - Change Position to Unit" will not leak.

09-25-2010, 06:55 PM	#8
Pyrogasm	Oh wow. Texttag functions were always strange.