Can someone help me with cleaning up this trigger?

Ok. There are about 6 triggers like this. All 6 are JUST for player 1. Theres 8 players. For another player to do this, the only way i can see is having to go through and make ALL different variables for all different units.. different regions, ect. Is this what im going to have to do.. or is there an easier method? These pics go in order. The first turns on the second.

Ok, heres links to the pics in order.

you could set each region to a variable array, and then do a "pick every player in [all players] and do...." making the variable use the value in the array of the picked player. :D

...i hate making b.net maps... everything becomes [number of players] times more complicated. :bgrun:

fixed

Well, seeing as how my crapass image host wont work. Arg.. ANyhow, thats what im doing. But i have like 30 regions. 30 units that get moved into those regions and then get triggered to set off an ability. Thats 60 variables -.- 60 x 8 = 480 -.-



:////

Bump* Got pics working

Copy as text.

The images don't work.

Arg.. STUPID image hosting =( anyhow, i mean repititive things like this.. things that im going to have to make mass new variables for

call MoveRectToLoc( udg_Player1Research1[1], OffsetLocation(GetOrderPointLoc(), -210.00, -240.00) )
call MoveRectToLoc( udg_Player1Research1[2], OffsetLocation(GetOrderPointLoc(), 150.00, -230.00) )
call MoveRectToLoc( udg_Player1Research1[3], OffsetLocation(GetOrderPointLoc(), -50.00, -210.00) )
call MoveRectToLoc( udg_Player1Research1[4], OffsetLocation(GetOrderPointLoc(), 230.00, -170.00) )
call MoveRectToLoc( udg_Player1Research1[5], OffsetLocation(GetOrderPointLoc(), -180.00, -110.00) )
call MoveRectToLoc( udg_Player1Research1[6], OffsetLocation(GetOrderPointLoc(), 70.00, -90.00) )
call MoveRectToLoc( udg_Player1Research1[7], OffsetLocation(GetOrderPointLoc(), -110.00, -70.00) )
call MoveRectToLoc( udg_Player1Research1[8], OffsetLocation(GetOrderPointLoc(), -200.00, 65.00) )
call MoveRectToLoc( udg_Player1Research1[9], OffsetLocation(GetOrderPointLoc(), -20.00, 90.00) )
call MoveRectToLoc( udg_Player1Research1[10], OffsetLocation(GetOrderPointLoc(), 220.00, 100.00) )
call MoveRectToLoc( udg_Player1Research1[11], OffsetLocation(GetOrderPointLoc(), -200.00, 200.00) )
call MoveRectToLoc( udg_Player1Research1[12], OffsetLocation(GetOrderPointLoc(), 190.00, 230.00) )

and -

function Trig_Fifth1C_Actions takes nothing returns nothing
call SetUnitPositionLoc( udg_ThunderClapUnits[1], GetRectCenter(udg_Player1Research1[1]) )
call IssueImmediateOrderBJ( udg_ThunderClapUnits[1], "thunderclap" )
call AddSpecialEffectLocBJ( GetRectCenter(udg_Player1Research1[1]), "Abilities\\Spells\\Human\\Thunderclap\\ThunderClapCaster.mdl" )
call PolledWait( 0.10 )
call SetUnitPositionLoc( udg_ThunderClapUnits[2], GetRectCenter(udg_Player1Research1[2]) )
call IssueImmediateOrderBJ( udg_ThunderClapUnits[2], "thunderclap" )
call AddSpecialEffectLocBJ( GetRectCenter(udg_Player1Research1[2]), "Abilities\\Spells\\Human\\Thunderclap\\ThunderClapCaster.mdl" )
call PolledWait( 0.10 )
call SetUnitPositionLoc( udg_ThunderClapUnits[3], GetRectCenter(udg_Player1Research1[3]) )
call IssueImmediateOrderBJ( udg_ThunderClapUnits[3], "thunderclap" )
call AddSpecialEffectLocBJ( GetRectCenter(udg_Player1Research1[3]), "Abilities\\Spells\\Human\\Thunderclap\\ThunderClapCaster.mdl" )
call PolledWait( 0.10 )
call SetUnitPositionLoc( udg_ThunderClapUnits[4], GetRectCenter(udg_Player1Research1[4]) )
call IssueImmediateOrderBJ( udg_ThunderClapUnits[4], "thunderclap" )
call AddSpecialEffectLocBJ( GetRectCenter(udg_Player1Research1[4]), "Abilities\\Spells\\Human\\Thunderclap\\ThunderClapCaster.mdl" )
call PolledWait( 0.10 )
call SetUnitPositionLoc( udg_ThunderClapUnits[5], GetRectCenter(udg_Player1Research1[5]) )
call IssueImmediateOrderBJ( udg_ThunderClapUnits[5], "thunderclap" )
call AddSpecialEffectLocBJ( GetRectCenter(udg_Player1Research1[5]), "Abilities\\Spells\\Human\\Thunderclap\\ThunderClapCaster.mdl" )
call PolledWait( 0.10 )
call SetUnitPositionLoc( udg_ThunderClapUnits[6], GetRectCenter(udg_Player1Research1[6]) )
call IssueImmediateOrderBJ( udg_ThunderClapUnits[6], "thunderclap" )
call AddSpecialEffectLocBJ( GetRectCenter(udg_Player1Research1[6]), "Abilities\\Spells\\Human\\Thunderclap\\ThunderClapCaster.mdl" )
call PolledWait( 0.10 )
call SetUnitPositionLoc( udg_ThunderClapUnits[7], GetRectCenter(udg_Player1Research1[7]) )
call IssueImmediateOrderBJ( udg_ThunderClapUnits[7], "thunderclap" )
call AddSpecialEffectLocBJ( GetRectCenter(udg_Player1Research1[7]), "Abilities\\Spells\\Human\\Thunderclap\\ThunderClapCaster.mdl" )
call PolledWait( 0.10 )
call SetUnitPositionLoc( udg_ThunderClapUnits[8], GetRectCenter(udg_Player1Research1[8]) )
call IssueImmediateOrderBJ( udg_ThunderClapUnits[8], "thunderclap" )
call AddSpecialEffectLocBJ( GetRectCenter(udg_Player1Research1[8]), "Abilities\\Spells\\Human\\Thunderclap\\ThunderClapCaster.mdl" )
call PolledWait( 0.10 )
call SetUnitPositionLoc( udg_ThunderClapUnits[9], GetRectCenter(udg_Player1Research1[9]) )
call IssueImmediateOrderBJ( udg_ThunderClapUnits[9], "thunderclap" )
call AddSpecialEffectLocBJ( GetRectCenter(udg_Player1Research1[9]), "Abilities\\Spells\\Human\\Thunderclap\\ThunderClapCaster.mdl" )
call PolledWait( 0.10 )
call SetUnitPositionLoc( udg_ThunderClapUnits[10], GetRectCenter(udg_Player1Research1[10]) )
call IssueImmediateOrderBJ( udg_ThunderClapUnits[10], "thunderclap" )
call AddSpecialEffectLocBJ( GetRectCenter(udg_Player1Research1[10]), "Abilities\\Spells\\Human\\Thunderclap\\ThunderClapCaster.mdl" )
call PolledWait( 0.10 )
call SetUnitPositionLoc( udg_ThunderClapUnits[11], GetRectCenter(udg_Player1Research1[11]) )
call IssueImmediateOrderBJ( udg_ThunderClapUnits[11], "thunderclap" )
call AddSpecialEffectLocBJ( GetRectCenter(udg_Player1Research1[11]), "Abilities\\Spells\\Human\\Thunderclap\\ThunderClapCaster.mdl" )
call PolledWait( 0.10 )
call SetUnitPositionLoc( udg_ThunderClapUnits[12], GetRectCenter(udg_Player1Research1[12]) )
call IssueImmediateOrderBJ( udg_ThunderClapUnits[12], "thunderclap" )
call AddSpecialEffectLocBJ( GetRectCenter(udg_Player1Research1[12]), "Abilities\\Spells\\Human\\Thunderclap\\ThunderClapCaster.mdl" )
call DisableTrigger( GetTriggeringTrigger() )
call PolledWait( 3.00 )