What do you think of this set of triggers?

05-18-2004, 01:14 AM

I was hoping some people could give a look at these triggers, and tell me what you think of them. Are they efficient? Is there an easier way to do them? Did the person who made these triggers put more effort into them than they should have? I was thinking that variables could have been used to make this job much easier, but I don't know. Please, give me your thoughts.

Quote:

Level6
Events
Conditions
Actions
-------- Level 6 --------
Countdown Timer - Create a timer window for (Create a periodic One-shot timer lasting 30.00) with title Level 6 Starts In:
Wait 30.00 seconds
Countdown Timer - Destroy (Last created timer window)
Game - Display to (All players controlled by a User player) the text: Level 6: |c009BC8FF...
-------- Level 6 Spawning --------
If (All Conditions are True) then do (Then Actions) else do (Else Actions)
If - Conditions
(Player 1 (Red) slot status) Equal to Is playing
Then - Actions
Unit - Create 2 |c009BC8FFSluggish Bird |r |cffffcc00(LVL 6)|r for Player 12 (Brown) at (Center of Spawn A <gen>) facing 0.00 degrees
Unit - Create 2 |c009BC8FFSluggish Bird |r |cffffcc00(LVL 6)|r for Player 12 (Brown) at (Center of Spawn B <gen>) facing 0.00 degrees
Wait 1.00 seconds
Unit - Create 2 |c009BC8FFSluggish Bird |r |cffffcc00(LVL 6)|r for Player 12 (Brown) at (Center of Spawn A <gen>) facing 0.00 degrees
Unit - Create 2 |c009BC8FFSluggish Bird |r |cffffcc00(LVL 6)|r for Player 12 (Brown) at (Center of Spawn B <gen>) facing 0.00 degrees
Wait 1.00 seconds
Unit - Create 2 |c009BC8FFSluggish Bird |r |cffffcc00(LVL 6)|r for Player 12 (Brown) at (Center of Spawn A <gen>) facing 0.00 degrees
Unit - Create 2 |c009BC8FFSluggish Bird |r |cffffcc00(LVL 6)|r for Player 12 (Brown) at (Center of Spawn B <gen>) facing 0.00 degrees
Wait 1.00 seconds
Else - Actions
Do nothing
If (All Conditions are True) then do (Then Actions) else do (Else Actions)
If - Conditions
(Player 2 (Blue) slot status) Equal to Is playing
Then - Actions
Unit - Create 2 |c009BC8FFSluggish Bird |r |cffffcc00(LVL 6)|r for Player 12 (Brown) at (Center of Spawn A <gen>) facing 0.00 degrees
Unit - Create 2 |c009BC8FFSluggish Bird |r |cffffcc00(LVL 6)|r for Player 12 (Brown) at (Center of Spawn B <gen>) facing 0.00 degrees
Wait 1.00 seconds
Unit - Create 2 |c009BC8FFSluggish Bird |r |cffffcc00(LVL 6)|r for Player 12 (Brown) at (Center of Spawn A <gen>) facing 0.00 degrees
Unit - Create 2 |c009BC8FFSluggish Bird |r |cffffcc00(LVL 6)|r for Player 12 (Brown) at (Center of Spawn B <gen>) facing 0.00 degrees
Wait 1.00 seconds
Unit - Create 2 |c009BC8FFSluggish Bird |r |cffffcc00(LVL 6)|r for Player 12 (Brown) at (Center of Spawn A <gen>) facing 0.00 degrees
Unit - Create 2 |c009BC8FFSluggish Bird |r |cffffcc00(LVL 6)|r for Player 12 (Brown) at (Center of Spawn B <gen>) facing 0.00 degrees
Wait 1.00 seconds
Else - Actions
Do nothing
If (All Conditions are True) then do (Then Actions) else do (Else Actions)
If - Conditions
(Player 3 (Teal) slot status) Equal to Is playing
Then - Actions
Unit - Create 2 |c009BC8FFSluggish Bird |r |cffffcc00(LVL 6)|r for Player 12 (Brown) at (Center of Spawn A <gen>) facing 0.00 degrees
Unit - Create 2 |c009BC8FFSluggish Bird |r |cffffcc00(LVL 6)|r for Player 12 (Brown) at (Center of Spawn B <gen>) facing 0.00 degrees
Wait 1.00 seconds
Unit - Create 2 |c009BC8FFSluggish Bird |r |cffffcc00(LVL 6)|r for Player 12 (Brown) at (Center of Spawn A <gen>) facing 0.00 degrees
Unit - Create 2 |c009BC8FFSluggish Bird |r |cffffcc00(LVL 6)|r for Player 12 (Brown) at (Center of Spawn B <gen>) facing 0.00 degrees
Wait 1.00 seconds
Unit - Create 2 |c009BC8FFSluggish Bird |r |cffffcc00(LVL 6)|r for Player 12 (Brown) at (Center of Spawn A <gen>) facing 0.00 degrees
Unit - Create 2 |c009BC8FFSluggish Bird |r |cffffcc00(LVL 6)|r for Player 12 (Brown) at (Center of Spawn B <gen>) facing 0.00 degrees
Wait 1.00 seconds
Else - Actions
Do nothing
If (All Conditions are True) then do (Then Actions) else do (Else Actions)
If - Conditions
(Player 4 (Purple) slot status) Equal to Is playing
Then - Actions
Unit - Create 2 |c009BC8FFSluggish Bird |r |cffffcc00(LVL 6)|r for Player 12 (Brown) at (Center of Spawn A <gen>) facing 0.00 degrees
Unit - Create 2 |c009BC8FFSluggish Bird |r |cffffcc00(LVL 6)|r for Player 12 (Brown) at (Center of Spawn B <gen>) facing 0.00 degrees
Wait 1.00 seconds
Unit - Create 2 |c009BC8FFSluggish Bird |r |cffffcc00(LVL 6)|r for Player 12 (Brown) at (Center of Spawn A <gen>) facing 0.00 degrees
Unit - Create 2 |c009BC8FFSluggish Bird |r |cffffcc00(LVL 6)|r for Player 12 (Brown) at (Center of Spawn B <gen>) facing 0.00 degrees
Wait 1.00 seconds
Unit - Create 2 |c009BC8FFSluggish Bird |r |cffffcc00(LVL 6)|r for Player 12 (Brown) at (Center of Spawn A <gen>) facing 0.00 degrees
Unit - Create 2 |c009BC8FFSluggish Bird |r |cffffcc00(LVL 6)|r for Player 12 (Brown) at (Center of Spawn B <gen>) facing 0.00 degrees
Wait 1.00 seconds
Else - Actions
Do nothing
If (All Conditions are True) then do (Then Actions) else do (Else Actions)
If - Conditions
(Player 5 (Yellow) slot status) Equal to Is playing
Then - Actions
Unit - Create 2 |c009BC8FFSluggish Bird |r |cffffcc00(LVL 6)|r for Player 12 (Brown) at (Center of Spawn A <gen>) facing 0.00 degrees
Unit - Create 2 |c009BC8FFSluggish Bird |r |cffffcc00(LVL 6)|r for Player 12 (Brown) at (Center of Spawn B <gen>) facing 0.00 degrees
Wait 1.00 seconds
Unit - Create 2 |c009BC8FFSluggish Bird |r |cffffcc00(LVL 6)|r for Player 12 (Brown) at (Center of Spawn A <gen>) facing 0.00 degrees
Unit - Create 2 |c009BC8FFSluggish Bird |r |cffffcc00(LVL 6)|r for Player 12 (Brown) at (Center of Spawn B <gen>) facing 0.00 degrees
Wait 1.00 seconds
Unit - Create 2 |c009BC8FFSluggish Bird |r |cffffcc00(LVL 6)|r for Player 12 (Brown) at (Center of Spawn A <gen>) facing 0.00 degrees
Unit - Create 2 |c009BC8FFSluggish Bird |r |cffffcc00(LVL 6)|r for Player 12 (Brown) at (Center of Spawn B <gen>) facing 0.00 degrees
Wait 1.00 seconds
Else - Actions
Do nothing
If (All Conditions are True) then do (Then Actions) else do (Else Actions)
If - Conditions
(Player 6 (Orange) slot status) Equal to Is playing
Then - Actions
Unit - Create 2 |c009BC8FFSluggish Bird |r |cffffcc00(LVL 6)|r for Player 12 (Brown) at (Center of Spawn A <gen>) facing 0.00 degrees
Unit - Create 2 |c009BC8FFSluggish Bird |r |cffffcc00(LVL 6)|r for Player 12 (Brown) at (Center of Spawn B <gen>) facing 0.00 degrees
Wait 1.00 seconds
Unit - Create 2 |c009BC8FFSluggish Bird |r |cffffcc00(LVL 6)|r for Player 12 (Brown) at (Center of Spawn A <gen>) facing 0.00 degrees
Unit - Create 2 |c009BC8FFSluggish Bird |r |cffffcc00(LVL 6)|r for Player 12 (Brown) at (Center of Spawn B <gen>) facing 0.00 degrees
Wait 1.00 seconds
Unit - Create 2 |c009BC8FFSluggish Bird |r |cffffcc00(LVL 6)|r for Player 12 (Brown) at (Center of Spawn A <gen>) facing 0.00 degrees
Unit - Create 2 |c009BC8FFSluggish Bird |r |cffffcc00(LVL 6)|r for Player 12 (Brown) at (Center of Spawn B <gen>) facing 0.00 degrees
Wait 1.00 seconds
Else - Actions
Do nothing
-------- Level 6 Spawning End --------
-------- Level 6 Waiting --------
Wait until ((Number of living |c009BC8FFSluggish Bird |r |cffffcc00(LVL 6)|r units owned by Player 12 (Brown)) Equal to 0), checking every 1.00 seconds
-------- Level 6 Waiting End --------
Player Group - Pick every player in (All players controlled by a User player) and do (Actions)
Loop - Actions
Player - Add 32 to (Picked player) Current gold
Game - Display to (All players controlled by a User player) the text: You Have Earned |cF...
-------- Level 6 End --------
Trigger - Run Level7 <gen> (checking conditions)

05-18-2004, 03:35 AM	#2
zotax	Using a loop would be easier, eg Code: For each integer from 1 to 6 If player((Integer A)) slot staus = Is Playing Then Create Birdie at Spawn A Wait 1 secound Create Birdie at Spawn B Im wary about using waits in loops, but it shuld work in your case

05-18-2004, 06:12 AM	#3
ThyFlame	It shouldnt matter in this case. There is no event response -- that is usually the only problem with waits in loops.

05-18-2004, 07:01 AM	#4
chuayw2000	You could use variables to store the units to be spawned for each level and the number and other information, sure saves your time as you can just easily do one trigger for all level spawns by using the variables.

05-18-2004, 04:30 PM

Magical-snaiL

Quote:

For each integer from 1 to 6
If player((Integer A)) slot staus = Is Playing Then
Create Birdie at Spawn A
Wait 1 secound
Create Birdie at Spawn B

I had a feeling something like that would work... sigh.