Help with War Drums Upgrade?

I have a hero which I have given War Drums to. Now I want to use a trigger to give the controlling player War Drums Damage Increase as Researched. So far I've not been able to get it to work. Here's some notes:

1) I created the hero using an Orc hero as the base
2) I have given the hero Uses Upgrade of War Drums Damage Increase
3) In a trigger which I have verified is firing, I have tried setting the value of War Drums Damage Increase to 1 (even tried 2 and 3)
4) I have other upgrades which I'm not having this problem with

What I see is +10% dmg from War Drums, but never see the additional 10% from the upgrade.

Anyone else messed with War Drums before, or have some suggestions of other things I could try?

In the Orcabilityfunc.txt file it has a requires=whatever thing. Remove that and it should work.

If you have more questions about upgrade editing i propose reading the "New upgrades, abilities" thread. Especially the posts which start with "This is so f****d!" and "IMPORTANT".

Martinez

Any other way to make this work without having to edit the game files? Not tried that yet, but I guess I could if no other option...

It depends on what type of map you are making. You could give the player whatever building War Drums needs and then instantly hide it. If you're making a melee map and War Drums needs an upgraded town hall (I can't remember off the top of my head), you can even remove the resulting supply limit increase in the same trigger.

So your saying that perhaps I need to set the player's Tech Level to 3 as well then? Don't remember having that problem with enabling BloodLust on another unit but it's worth a try.

Or perhaps you were referring to the Beastairy?

Gah wait, what am I talking about?

Unfortunately, sometimes WC3 doesn't like to assign upgrades if they are only 1 level through JASS script. I had that happen to me, too and had to resort to letting the player research it themself.

Would you believe this? I made a test map and put the hero, Fortress, War Mill, and Beastiairy down. Started the map with the Hero having War Drums and researched the upgrade. It completed but the Hero STILL didn't get the bonus...

Make sure he has the ability too, if he just uses the upgrade it won't work.

In the Unit Editor, under Custom Units, make sure your custom unit falls under the "Orc" catagory. That's the only reason I can think of that the researched upgrade wouldn't work, other then what dataangel said.