JASS Spell Pack 1

4 Spells I have recently made in GUI, completely rewritten in JASS, and as far as I can tell, leakless and multinstanceable. Includes 1 brand new spell, Flaming Cyclone, which is the one shown, which creates balls of fire around the caster rapidly, dealing damage to enemies caught in their path.

Also includes:
Blink Storm
Scatter Shot
Meteor
Righteous Blessing

Please dl and comment, and for you JASS gurus, any thoughts, comments, or critques would be great

Enjoy!

*Also included, for those who would like to use but have no clue about JASS, or would just like to compare GUI to JASS, are the same triggers I wrote before in GUI!

Please be kind, these are my very first JASS spells, and I too am very proud of them.

****updated to comply with some of Daelin's suggestions and a few other things I have learned since making these before!

I wonder why nobody commented these wonderful spells. Ok, let's comment!

At first testing, I found that the map slightly lagged. Even some of the spells caused slight lag. Except that, they were wonderful.

Now, getting into coding, I was surprised to see that you aded both JASS and GUI version. That is an awsome stuff indeed! I'll take spell by spell and come with comments (I didn't do heavy testing to find bugs and stuff).

1. RB
In FindUnitGroup you could replace the GetBooleanAnd function with a simple and between the two conditions (instead of the coma). Moreover, you can ignore the ==true. Another thing there was the IsUnitAliveBJ non-native. Replace it with GetUnitState(GetFilterUnit(), STATE_UNIT_LIFE)>0.

Moreover, start using coordinates. They are faster than locations and are not that complicated. You just use in place of a location, an x and an y real coordinate. You then no longer have to nullify or remove them.

I saw many other BJ functions. You can replace them with natives. Here, try this editor. Just copy-paste your code into it, and all non-native functions will be written in green with italics. You can then type them in the search bar, click on it in the list, and see the function itself. It is esier then to replace them.

And another thing (which Vex taught me): If you want to create and destroy an effect immediately just do this:
In this way, you can save a couple of rows.

2. Blink Storm
I noticed that the condition function for this spell remained untouched. Look at Trig_Blink_Storm_Fast_JASS_Conditions and you will understand. Other elements, look above. You are having quite the same problems.

There's nothing more I should add to the other spells. Just look at the stuff I mentioned above, and you can solve a lot of problems in your spells! That's all! Very nice spells, I find them very good for your first JASS attempt. You should be proud of them indeed.

~Daelin

ty, yea I just started using coordinates after reading one of your tuts. at The Helper, as well as changing all the blizzard.j functions to common.j

ty for the response, and the helpful comments, as well as the praise

as far as lag, I have not experienced any myself with nay of them, even running a few at one time, nad my comp isnt that great (3ghz), and as far as the map lagging, the only lag should be at the very first loading, when all the units are created around the map, other then that it should be fine

again ty for the response, I'll see what I can do to clean it up

Good spells, but I did hit some lag with that Righteous spell. Of course I'm running on a 1.5 Gig processor, but still, online that would lag bad most likely.

yea, I am running a 3ghz, 1gig ram, and it works smooth as silk at my end, I guess I didnt think of those ppl with older computers

the spell effect thoguh is what is causing the lag, and that is the effect I want, so I guess ppl with slow computers will just have to suffer through it

about lagging bad online, I duno, as long as it dont hurt anyone to bad as far as lag, it should be ok I think

While i am not qualified to speak of the technical quality of these spells i will attempt to give you some quick feedback on how i felt the abilties would feel in an actual map.


Blink Storm

Nifty, seen it before though.

Scatter Shot

Loved this one, felt really solid to use - intuative and interesting ++

Meteor

Another solid, intuitive spell

Righteous Blessing

Tooltip was clustered, spell apeared to have too many effects - remember, simple spells often play better in maps as it is easier to keep track of all the strategic permutations.

Flaming Cyclone

This spell i felt was a bit visualy... underwhelming, didn't seem as intuitive as the others.

just a small thing
you dont have to use call twice
you can just use
call DestroyEffect(AddSpecialEffect ... etc.

I thought I did that....o well

these WERE my first JASS spell attempts ever....so..... :)

btw BB Dino, I personally love Righteuos Blessing, but then some ppl dont, so that is ok

and Flaming Cyclone i think is neat, but maybe better fire effects are needed

could you make the balls of fire bigger on flaming cyclone and i didnt get any lag wit the RB spell but i guess people have worse computers... hmm i dont know JASS but all the spells cept Falmin Cyclone was awesome!

na cant really make em bigger unless I use diff effects, and that is the best fire looknig effect in the worl editor I think for that spell, unless you got better suggestions

how can i add them to my map

i added it but it says expected a function name

check for that function in the cs section of the map

dude blink storm ROCKS!

May you explain the spells in the thread? I'm not really interested in downloading every spell just to see what they are doing.

u only dl one map, they are all in the same map, you can choose to test them or not, its up to you