A few problems with this spell...

I have a few problems with this Maelstrom spell I am trying to make. The main one is that in the middle of this trigger where I set the variable p to equal the position of a random unit most of the time it doesn't work and p ends up equalling 0,0. The point of this spell is to create a large lightning storm where most of the time lightning just hits the ground around the caster but occaisionally a unit it is randomly selected and struck. Here is the code.


Sometimes it works fine. It always does damage to the random unit, but usually the lightning effect doesn't show. When I tell it to make floating text at p it puts it in the middle of the map, but strangely the lightning doesn't even show up there.

Another question I have is to do with the sound effect. Howcome if I tell it to destroy the last created sound right after triggering it it doesn't play even though the note says it will remove the sound when it is done playing. Now that I think about it I probably need to set the sound to a local variable and then wait and then remove the sound after it has had enough time to get started. Would that be right?

Third question: the dummy spell is based on Channel, how do I make it so that if the hero goes invisible or invincible the channeling is cancelled? That is what happens with most or all other channeling spells I think. Why doesn't it happen with anything I base off of Channel?

I don't know why nobody has any answers to any of my questions. I spent a few more hours looking into this problem. It turns out everything works if I create an effect directly at "Position of u" instead of setting p to equal Position of u and then creating an effect at p. But that way will leak, correct? How can I do this without leaking and without bugging???

Also, my theory with waiting for the sound to start wasn't true. How are you supposed to trigger sounds? And why does it seem like you can't play the same sound twice in quick succession? It waits for the previous sound to play all the way through before that sound can play again. And why doesn't putting a sound effect on an ability in the object editor do anything? Oops, that's not a trigger question.

that code just confuses me.... but 1 see 1 major issue right off the bat:

your declaring a local as "udg_". (udg is the prefix for globals, and as i see, you alredy have a global "e" (thus "udg_e"))

convert it to JASS and post it again, and ill try to help.

This code makes my eyes hurt :/
Why did you make IFs in Custom script?

I've heard that if you declare a local over a global you can use the global in the trigger as it was a local.

actually, you can do like this:
local effect udg_e

it gives you the possibility to use gui actions to the local effect. I only think it works for 1 global per function though.

custom script ifs are often used when you need to check... locals for example, or when you dont need the else.


If you want to make it stop just make a timer or something checking if the unit got those buffs, and then order it to stop.

To your TextTag problem, i suggest you check so that the TriggeringUnit actually is your unit after every loop.

Sorry if the code makes your eyes hurt, but as I said, the problem boils down to this: "myPos = Position of myUnit" doesn't work. At least not in my situation there, and it makes no sense. I forget what the custom Ifs were for but I was doing things different before, I think I was using an elseif or something. At least this way I can say "If udg_b" instead of "If b == True". And yes, I made a local with udg_ so I could access it with GUI functions, I haven't bothered to learn all of JASS so I find that the easiest way to do things.

my origional request stands: please post the trigger in full JASS.

The Unit Group - Pick every unit in unit group thing, it uses another function, so locals won't work, you would be setting the value of the global b instead of the local udg_b

for the record you don't even need to make it local, cause there are no waits during the time you use that variable.

You need a local for the effect variable instead

And you have a leak, In this part:

Position of (triggering unit) is creating a point you are not cleaning

The boolean "b" isn't a local. The only local I am using is for the effect, as needed.

Thanks for the tip Vex but how would I prevent that from leaking?

So I take it nobody knows why you can't set a point to the position of a unit variable? Or how to trigger sounds without them leaking?

You dont have any events -.- so you cant use triggering unit..

the trigger is probably executed by another trigger that has an event

Well then he cant use "triggering unit" as it doesnt referr to any unit or can he?

if that trigger was fired off by another trigger that had a compatable event (eg: unit enters reigon) then yes, he can. (its how allot of people did "if then else" statements for RoC (before multiple conditions / actions where given to us))

ok thats new to me :P