Bunkers Revisited

Trying to get bunkers to work in my map, but cannot for the love of god get it to function like the bunkers in starcraft.

Some notes:
1.) Each player in the game only has 1 bunker (and can only have 1).
2.) For simplicity's sake, I'm going to cut my code down to deal with only 1 type of unit, but bear in mind more than 1 unit-type can load into the bunker.
3.) I'm currently only working on Loading Units into a bunker and unloading a unit by clicking on its icon (not unloadall).
4.) I'm using the method of creating an invis/untargetable/zero-path unit on top of the bunker to track the different firing methods/etc.

How I handle loading:

And this is how I'm trying to unload them:
Note: I convert this trigger to JASS and then remove the comment tags to make the loop work.

What is the problem?

Lol sorry.
Problem is, the invis/locust/no-pathing units created aren't being removed from the game when the unit exits the bunker.

Wouldnt modifying orc burrows get the desired effect?

And there are problems with removing locust units, arnt there? Or is that only for adding them to groups based on what rect they are in?

Since they're getting created okay, I don't think the problem is with the transporting mechanism. Is it something with Locust, you think?

I dun believe so. I think it's the Orc Burrows who get their attack enabled and not the peons. And since this is so, he can only get 1 attack-type effect. I think that's why he's triggering in invisible units to make it appear as if there are multiple types of units inside the bunker attacking.

I think it has something to do with the Locust ability, though I'm not sure...

Oh, and by the way, you can still use loops in the GUI. Just use the custom script option.


I'm not 100% sure if that would work, but it should...

You cant pick a unit with locust
i.e. pick all units matching...

You can do last created unit etc.

Hmmm. If I can't "Pick" the unit with locust, I guess that means I have to use an array of units rather than unit-groups? I just assumed the built-in unit-group function would be easier since its sort of a dynamically expanding/contracting array, but if I can't Pick locusted units that's kind of a stupid design flaw.

Alright... I am seriously beyond frustrated with trying to get bunkers to work. I rewrote the code using arrays (its not pretty, but the loops and array management -seem- to work), and the invis units still dont get removed when a unit exits the bunker.
So I tried removing the Locust ability from them, and making the attempt to select them impossible via triggers.
Still not getting removed when the unit leaves the bunker.

Note: My array system is bizarre. It might be the problem and my error detection method might be deceiving me.
Basically, I'm trying to create a matrix of size 5x4; x coordinates = each players bunker, y coordinates = number of units currently inside the bunker.
Say you want to get the 2nd unit in Player 1's bunker. You would call BunkeredUnits[12]. I do this by a painful way of converting strings to integers.
Essentially to restate the code:
The 'X' coordinate = String(Player Number of Triggering Player))
The 'Y' coordinate = String(NumberOfUnitsInBunker(Player Number of Triggering Player)
Put together, the matrix location = Integer(X+Y) (con-cantenated)

I know there's better ways, but for the moment, it's working, and if it aint broke, I aint fixin it.


Here's all the relevant triggers:

Trigger to assign all normal, bunker-loadable units (marines, firebats, ghosts, medics) in the game specific custom values (These are used when to identify if an invis unit-type matches the appropriate unloading unit-type):
Note: the last line is just a testing trigger I put in to check the custom values are working properly.


Next here's my trigger for when a unit is loaded into a bunker:
Note: The last lines are just testing actions.


Last trigger - when a unit is unloaded by clicking on his portrait:


From testing with the text messages I made, it appears that my array handling via counters/loops/etc are working properly.
Ie:
1 unit is loaded to the bunker, printsout:
NumberOfBunkeredUnits[1] = 1
BunkeredUnit[11] = Marine with Custom Value: 2

2 units loaded to the bunker:
NumberOfBunkeredUnits[1] = 2
BunkeredUnit[12] = Marine with Custom Value: 2

1 marine is unloaded by clicking on portrait:
NumberOfBunkeredUnits[1] = 1
BunkeredUnit[11] = Marine with Custom Value: 2


In conclusion:
I have no f@$%$%cking idea why the invis Marine-Bunkered unit isn't getting deleted.

If anyone can figure out the error, I will worship you forever.
Just to clarify something, to: the Bunkered Units have Permanent Invisibility, but not Locust.

Wait wait wait...
"Custom script: (exitwhen ((Custom value of (Target unit of issued order)) Equal to (Custom value of TempUnitArray[counter]))) "
This is not proper JASS syntax, and shouldn't work at all.

Also he doesnt need to use JASS to make a loop.
Just use the "ForEachLoop" function.

And just so you don't think I'm a total retard I am planning on re-writing the array method to use something like Array[x*sizeofy+y-1] rather than the ridiculous string method.

Anyways... whats wrong with the JASS syntax of the exitwhen condition? Im a total JASS noob :/

is not valid jass syntax. It is just a GUIism.
I believe custom value is Set/GetUnitUserData. So:

Ahh... so obvious.
Although I didn't know the correct function, either.
Thanks a million... rep+ :D