| 06-07-2006, 07:31 PM | #1 | ||
Description: The Desert Lord returns to his true form, the sand itself. He then manipulates the sand and minerals to his advantage, damaging and stunning all units in his path. For the finale a giant stone hand forms, then crushes all units in the nearby area. Any time the Desert Lord hits a unit, the unit is knocked into the air, damaged and then stunned. Both damage amounts and stun duration increase with level. Screenshots: Download: Spell Contest 4 - Tim 3.2.w3x (50.7 kb) Notes: This was my entry for Spell Session 4, and it came in third place. The spell is meant to go with a model such as this one, in order to match the sandy theme of the spell. The Reveneant model used here is only an example. Also, the spell meets the JESP Standard, is much easier to configure than my former spell, and is completely customizable. Even includes a Variable Stun system! (Thanks to blu_da_noob for the original system.) |
| 06-07-2006, 09:10 PM | #2 |
A very nice spell, approved. There are, however, some things that can be improved in your future spells: You could make your configuration functions constant, that should make them run a bit faster. Using the same function for all returns of the same type seems silly. The if statements slows it down, and if they were not there, the functions would be replaced with the actual values in an optimized map.  JASS:function TremorTim_Cache takes nothing returns gamecache return TremorTim_Gamecache() endfunction This seems really pointless, a configuration function directly returning the return value of another configuration function in the same spell? Using TriggerSleepActions with animations is really bad idea. You do not need to use a timer and another function there, but polling a timer (look at the function PolledWait's code) would give you a more beautiful result. I don't really like that you use the same timer expiration function with a ton of if statements. Each if statement and declared variable that you do not use, is making the spell slower (even though it is not much). I suggest you to seperate it, you can always just restart the timer and make it run another function, without having to reattach things. Example: JASS:function ThirdTimerFunction takes nothing returns nothing local timer t = GetExpiredTimer() //actions actions actions actions if <condition if this part of the spell is over> then call DestroyTimer(t) endif set t = null endfunction function SecondTimerFunction takes nothing returns nothing local timer t = GetExpiredTimer() //actions actions actions actions if <condition if this part of the spell is over> then call TimerStart(t, 0.04, true, function ThirdTimerFunction) endif set t = null endfunction function FirstTimerFunction takes nothing returns nothing local timer t = GetExpiredTimer() //actions actions actions actions if <condition if this part of the spell is over> then call TimerStart(t, 0.04, true, function SecondTimerFunction) endif set t = null endfunction |
| 06-07-2006, 11:48 PM | #3 | |||||
Quote:
Ouch, can't believe I forgot to add that in the end. Will fix. Quote:
Oh alright, I figured it was better like that :P I won't do it in the future. Quote:
That's left over from a test I was running, forgot to remove it I guess. I'll fix that. Quote:
Will do in the future, thanks. Quote:
Like before, I assumed it was the best way. Won't do so again. |
| 06-08-2006, 06:19 AM | #4 |
| 06-09-2006, 03:27 PM | #5 |
| 07-23-2006, 02:19 PM | #6 |
| 08-08-2007, 09:55 AM | #7 |
| 08-08-2007, 10:34 AM | #8 |
| 08-08-2007, 01:09 PM | #9 |
| 08-08-2007, 10:26 PM | #10 |
| 08-09-2007, 07:18 AM | #11 |
| 08-09-2007, 07:21 AM | #12 |
| 08-09-2007, 12:15 PM | #13 |
| 07-14-2008, 02:27 AM | #14 |
| 07-29-2008, 11:14 AM | #15 |