Chill of the Earth

Description: The temperature of the air surrounding any unit with this spell is so low that it actually congeals the land over which it travels. Any enemy units caught within this frozen earth will have a chance to fall over and slide when they are issued an order instead of following the order, then stunning them on the ground for an additional X seconds. (X is a constant that can be changed)

Background: Well I made this for the Spell Session #4. It didn't go over too terribly well, only got one honorable mention. But oh well, maybe someone else can find it useful. I took some of Vuen's advice and modified it slightly to make it more useful. I didn't go back and make a % chance every X seconds though, however I can if enough people would like to see it.

Special Thanks: All credits to anything I used are in the map, but I want to thank Vuen & Naakaloh for being the only people to offer real feedback on the spell, even if it was after the contest had ended. Apologies to Naak for not noticing he even looked at it, I wasn't aware he commented on EVERY spell, not just his top three. :P


Anyways, I hope you all enjoy.
Give credits where they're deserved if this should make its way into anyone's map.

Screenshot:

What about me? I tried to give some feedback and you're spell was my second choice. I feel sad and ignored now. Oh well, anyway, good choice with checking for the tileset, it doesn't look as odd. If you still want suggestions, I still recommend reverting the tileset back to whatever it was instead of snow, but hey, it's your choice, it doesn't really affect gameplay unless it changes an unbuildable terrain type to a buildable one.

Edit: Just ran the map... Apparently there's an issue with occasionally neglecting to change the ice.

That is one of the requirements for the JESP Standard, and your spell uses a global specific to it (the unit group).


Like half of your cote_ functions are in the map's custom script section.

Why do you not use the original version of the handle variables? It is annoying when everybody uses their own renamed versions, makes importing spells harder.

You do not set a timer to null a single place, why not?

The bug is very rare, you should only care about it when you see it. And I doubt it has happened in every single function in the map.

When you use GetTriggerUnit many times in the same function, it gets inefficient. Better save it in a local in the start of the function (the function I am talking about is cote_SlideConditions, it might be the same other places too).

Why do you use GetRandomReal(1, 100) for the percentage? Most people use 0, 100, for a reason. 0 is also a valid percentage.
________________

It is a nice spell, but you have to fix some things before it can be approved.
If you have the JESP Document in your map, the spell MUST follow the standard to be approved.
I suggest looking at the other points I wrote too.

It should be GetRandomReal(0,99.99999) :P Agree with everything else Blade said.

Also:
Could be:
Saving a function call.

You also repeatedly use GetEnumUnit() in cote_GroupTerrainEffect (similar to the TriggerUnit thing mentioned by Blade).

You use a MoveUnitToPolarProjection, which is very inefficient. The direction the units are moving in doesn't change, so store the Sin/Cos of the angle and use those directly. Why do you have two separate function for movement and rotation anyway? It ends up with two 0.033 repeating timers per unit, a single one would be much better.

Alright, I'll go through and work out everything you all mentioned.
Give me a bit and I'll update it.

Sorry everything was so screwy, Blade, it appears you got kinda angry at the spell.
Apologies for not following JESP perfectly, it was my first time, I'll fix it all right away.

Naak, apologies! I wasn't aware you went through every spell! Thanks! >_<
(I fixed the top too!)

EDIT: OK!
It's all redone, the update is at the top.

A great improvement, good work. A couple more things that could be improved though ^^.


Instead of calculating bj_PI/180 everytime, use either the constant bj_DEGTORAD, or the actual value of pi/180.


Should be less than ^^. You're inverting the % chance atm (to see it easily, look what would happen if you gave it 100% chance).


GroupEnumUnitsInRect is a common.j function and, as such, does not clean up the boolexpr. You will need to do it manually.


The last thing is the fact that you have the handle variables in two separate places, and your installation instructions make it sound like you should copy both sets over. Maybe just clarify that a little.

The first one I can fix in a split second, no prob.
The second one I must have been an idiot for doing, that's what happens when you don't pay 100% attention, -_-.

And yeah, I'll set the BoolExpr to a var and clean it up myself.
I'll update in like ten minutes.

EDIT: There, fixed, fixed, and fixed.
That's everything you mentioned. Sorry there was so much wrong with it. -_-;;

You still haven't clarified about the installation of the handle vars, but it's not vital, and I'll approve in anticipation of it being rectified.

Alright, well I went back and rewrote that whole section.
It should be much clearer on how to add handle vars to any given map now.

Let me know if I need to add more. :P

Seems fine to me.

Reminds me of Morran in the Mumin trolls. xD Everywhere she walks turn into ice.

For the unknowing

Have to say I'm not impressed, not by the coding, kudos on that! But on the actual usage of the spell... Wouldn't it be possible to change it to maybe, every time a unit attacks instead of is issued an attack order ? And keep the move order... that would make the unit drop alot more, and actually make it valuable to implement.