Problems with loops?

Hello everyone, in my wmw map I have a few triggers that keep track of the shrines when they are replaced, upgraded, or autoupgraded at 2000 income. I have all of the triggers using "for each integer A", and every once in awhile it gives me problems. Even though I know that all my shrines are being tracked correctly, sometimes the auto upgrade trigger will fire over and over and constantly replace the shrine after 2000 income, even though the trigger can only fire if shrine tracker is a certain type.

This trigger sets the shrines to a variable right at the start.

This trigger replaces the shrines if superspeed is set, and remembers what it was.

This trigger upgrades the shrines manually.

This trigger auto upgrades the shrine.

I think the problem is either with the upgrade trigger, autoupgrade trigger, or there is a problem with using "for each integer A" or im not using it correctly. Any help will be appreciated.

Using For Loop Integer A with Waits is dangerous because Integer A is a global value meaning it can be overridden in other triggers. Change that to For Each (Variable) being a local variable and all should be well.

Eventually you can use the trick with local globals, and put a

You can only use this bug on one variable per trigger, though. And it will cause problems if you use stuff like Pick Every Units In <Something> or Pick Every Player In <Something> in your trigger.

ok i took the time and read vexorians post on local variables to understand them a little better found here. So, all I have to do is put this line of custom text at the start of the trigger, and refer to that integer instead of using integer A?


correct me if this is wrong.

Edit: Ok, in this case it is wrong. After reading a little more thoroughly about this subject and testing this failed trigger, I learned that locals cannot be used in the if/then/else actions. this creates a problem in the case i need the conditions to be checked every 8 seconds and match the player inside of the loop, but in this case, how can it be avoided? Should I just use a different global for each trigger that uses if/then/else instead? The above trigger crashed my game when it fired, but didn't when i removed the custom text.

And one last thing. The reason I use the wait command at all is because for some reason without that small delay the shrine sometimes did not get replaced. Using the wait fixed that but caused this problem.

hmm, i say you global idea. WAIT command in loop with "integer A" or "integer B" will make a bug if TWO or more loops runs at one time. Example: loop1 starts and when a=3 starts loop2. loop2 sets a=1 while loop1 is waiting. understand? A is global variable for all loops. if you want to run loops with wait action at one time, use local variables. you can use custom scrips for this idea.

Custom script: local integer a
Custom script: set a = 1
Custom script: loop
Custom script: exitwhen a > 20
Unit - Move air instantly to ((Position of land) offset by (((Distance between (Position of air) and (Position of land)) x 0.90) - 1.00) towards (Angle from (Position of land) to (Position of air)) degrees), facing ((Facing of land) + (((Facing of air) - (Facing of land)) x 0.80)) degrees
Wait 0.05 seconds
Custom script: set a = a + 1
Custom script: endloop