Spell Session 4 - Disco Inferno (JESP)

Description

Turns the target location into a dancefloor that lures enemies within a range and deals damage and stuns them in a final explosion.

Notes

By replacing the discoball with a meteor/stone model, the dancefloor with a earthquake or similar texture and replacing the disco sound this can easily fit in many maps.

This map also shows a JASS unit sound system. This system allows us to use mp3 files for unit sound sets. It's used for the hero in this map.

Credits

CSCache, SimError Functions and Dummy.mdx Model by: Vexorian
LensFlare.mdx Model by: Rao Dao Zao (this makes the wonderful lens flare effect at the end)
DiscoDude.mdx and DiscoBall.mdx Models and Textures by: RightField
Original WhiteExplosion.mdx Model by: JetFangInferno
DarkPortalUberSplatSE.blp created from Ice Tiles by: Ice
Disco sounds extracted from: The Simpsons

I'm gonna leave the code review till tomorrow (on the tired side now, so I'm liable to make mistakes :P). Just had to say that the execution of this is really smooth :). Le awesome.

I am approving it. I should talk about X site that has 80 times more spells than us but we beat them 1000 to 1 in impressiveness

I'll check it out tomorrow anyway, just in case anything can be improved :P


I think 80 is a bit low. Probably more like 500.

PitzerMike: your spell is really funny. +rep

Actually it is very usefull, and I prefer it without "DanceFloor", so it useable for other things, then a "DiscoTheme" Keep up the good work =)

In function Disco_Inferno_BeforeCastHandler:
You leak two locations. (Same thing appears in Disco_Inferno_StartEffectHandler)
As easy fix to that could be to just make the DetermineDanceFloorType function take a location instead of x/y coords and destroy the location inside it.

All attached variables attached to public objects must have the spell code prefix + "_" to comply with the JESP.

In your Disco_Inferno_CreateTextTag function, remove the wait and destruction of the texttag. Setting the texttag lifespan cleans it up automatically and frees its handle reference to be used by another texttag (meaning your DestroyTextTag could destroy a different one).

Disco_Inferno_ResetUnits lacks a nulling of unit variable. Ditto with Disco_Inferno_IsValidTarget. Disco_Inferno_IsDestructableTree lacks nulling of a destructable.

Thanks for the code review. I have now fixed the leaks that I had overlooked + the jesp prefixes. New version uploaded.

Shrugs, I can't hold back anymore to say that this is the coolest spell I have ever seen!

OMG IM SO HAPPY SOMEONE USED MY TILE SET :P LOL

Glass Floor

Wow, freakin awesome spell. Have to give rep for that.

damn you all! xD i wanna learn Jass more and more every day, just cat figure the damn thing out... even though im pretty handy at making homepages -.-

- Awsome job gonna use it in my map, im not sure if you want cradit or not, could you PM me back on that one?

awesome spell.
if i have time i would cr8 some mini-rpg but i haven't

This spell wins - I don't think it's possible to compete with this, the bar is to high!

10/10 :P

I agree this spell rockz!!!!