Further help with suicide ability

I had another thread on the forums, where I was having trouble making an ability. I have finished the ability, but it doesn't work as I want it to. Basically, it detonates the caster and heals allies nearby = Casters life / number of people nearby. (damages enemies too, but that part of the trigger works fine, so I'm not worrying about including that at the moment). The initial trigger was very simplistic, but I found that a lot of health was being lost, and the overall health was not retained, and I have tried a lot of things to fix this. At the moment, I think it is fine, I am quite sure that no health is being lost, due to uneven division etc.

Sometimes the ability works fine, sometimes it doesnt:

Eg. I have 4 units at 50 hp, I select them all and detonate them. I now have 2 units at 100 hp(max). In this instance, it worked.

I have 8 units with 25 hp each, I select them all and detonate them. They all blow up and I have 0 left.

I want to make it so the total hp is conserved, and even if you detonate 12 units at a time, you will be left with units, whose total hp will be the same as before.

Here is the trigger.


I know, It's probably a lot bigger than it needs to be, but I'm not very good at this stuff yet , havn't mapped for a while...

So... I was wondering if anyone could isolate the problem, and tell me what is making it not work. Also, any suggestions as to ways I could clean up the trigger would be nice.

Thanks.

Maybe the trigger is picking units it shouldn't.
debug it all, add a -game message- action once a while, specially in the loops. u know, like;
then, u just go and cast the skill once. go to messages log and there u have a nice list of messages your trigger created.
there u can realize what's wrong.

(i hope i did write it all ok.)

K sweet.. I'll do that when I have time and reply with results. Ty.

Ok I ran a test, here are the results:

4 units in temp group, 25 hp each, 207 total
5 units in temp group, 6 hp each, 2 extra hp for 1 unit, 207 hp total
3 units in temp group, 2 hp each, 2 extra hp for 1 unit, 207 hp total
5 units in temp group, 11 hp each, 4 extra hp for 1 unit, 207 hp total
4 units in temp group, 24 hp each, 2 extra hp for 1 unit, 207 hp total
3 units in temp group, 27 hp each, 1 extra hp for 1 unit, 207 hp total
1 units in temp group, 76 hp each, 41 spilled amongst units, 243 hp total

At the end of this, I have one guy left at 55 hp, nowhere near 243. (max hp of the unit type is 100). How can total hp be 243 when it isn't? the trigger I used to check the amount of total hp was this:
Perhaps that problem is with the spilling health part of the trigger? It still doesn't prove why it kills all of the units in certain instances...

Hope this helps someone understand it more, because it only serves to confuse me more, lol .

in your else options, get rid of the action. Itll automatically set it as nothing

above your Unit groups put stops a leak :)

K sweet thanks. Any other opinions on how to clean up the trigger, or make it work properly would be greatly appreciated.

Sorry to have to bump this, but I really need some help getting this trigger to work properly.

Thanks.

I'm not quite sure about what you want help with? Are you "fusing" units together?

What exactly is this spell supposed to do? It's too complecated to work out without WE or investing more time than i have.

you can make totalhealth an real variable so you dont have to convert it to integer

Basically what the ability is mean to do is kill the caster distributing their health they had as health amongst allies, where the total health is conserved. Ie: I have 1 guy at 100 hp and 2 at 50 hp. I order the unit at 100 hp to cast this spell, he will die, and the other two units are at 100 hp each. (Health before [100+50+50] = health after [100 + 100].

Other than perhaps problems with the working of this health distribution that I might have missed, the main problem is when getting more than one unit to cast it at the same time. No unit is meant to cast the ability if there is noone under 100 hp (full health) to heal. Sometimes it works (usually when like 4 or under units), sometimes all units cast it and all blow up. (healing... who?)

I did a test, and with text messages, it said for the total health, that it was all there, when I had only one unit left(with a fraction of that hp),

So.. I hope that clears some things up, lol.

u know.. if u order a unit to cast detonate, it won't stop no matter what your trigger says. Cuz the event is - unit starts the effect...

i wouldn't use Detonate ability but..

if the unit shouldn't cast it, create another trigger to stop him.
use the - unit begins casting - event. then order him to stop immediately, no waits.

edit: btw, consider that the Pick action may be picking the casting unit too.

I didn't base the ability of detonate, I based it off 'Roar'. Also, I tried to eliminate the caster from the selected units, and I don't think he is in any of the groups...

So... I really don't know what to do, lol.

mmh...
maybe... save the trigger, the spell, everything. then create slowly all over again. and remember the messages actions, to know what's coming on inside the trigger.

testing that way surely u'll find where the trigger is failing and then u'll go back to the original one as a new man with no mistakes(?).

No! dont let the dark side tempt you!