| 01-31-2007, 07:28 PM | #2 | |
Quote:
We should probably just call it the "standard" format henceforth. xD I really liked this hero, it added a neat melee hero to a map. Notably, I also liked the fluid blend of caster and tank into the same hero, it's a nice concept. However, a lot of the abilities still feel a bit complex for the WC3 melee setting. For example, I think Insidious Beacon is a little too "Hunh?" for a melee map. However, I feel overall the hero was very well made and had a solid concept. I haven't had a chance to look at the code, but I'll take a gander when I get a chance. Nicely done, Daelin. |
| 01-31-2007, 08:56 PM | #4 |
Will you use this in RotHE? Oh, and +rep! |
| 01-31-2007, 10:54 PM | #5 | |
Quote:
Though I admit I was inspired by Tim's avatar collection because I didnt know how tables worked on wc3c before that. ANYWAYS Looks cool but I think the blood elf leuitenant model would actually go better with this. I bet you're aldready using that one for RoTHE but for normal ppl who DL this map I think it would go better with that one. |
| 01-31-2007, 11:14 PM | #6 |
I really like this hero. Another one Ill add into DoD, thx^ |
| 02-01-2007, 02:59 PM | #7 |
Things to look at: Excessive use of ==false in some condition functions. Use not? Do not use non-temporary BJ globals to store stuff. People may use those in GUI. Use ones that only have instant use (ie bj_GroupAddGroupDest and bj_GroupCurrentRandomPick (only rough names, but should get you there)) It appears that in function BloodMana_SSDo, timer tt is not always destroyed. (Looks like the same for timer t in function BloodMana_Main) In function Martyrism_Main, you should start your damage refresh timer with a duration of 0. Radiance is going to cause bugs if the hero acquires any health modifying items while it is running. |
| 02-01-2007, 03:17 PM | #8 |
I love the new icons, of course you have to remove the border in the passive one. Just one question: Blood mana in the hero contest worked in allied units? or it's just an improvement in this version? As soon as I fix my computer, I'll test again your hero. |
| 02-01-2007, 03:18 PM | #9 |
I'm glad to see that more and more members around here are setting up their post(s) in a decent way (afterall, the users are submitting resources to/in a forum board :P not an actual *resource upload section*)Anyway, you did a good job making this hero, Daelin. I like it even more now with the new icons included :P (fits perfectly) How about taking it further, eh? A custom texture for the model xD -- Nonetheless, keep it up |
| 02-01-2007, 03:32 PM | #10 |
Well, yes, I seek to make this super original. So new SFXs for the spells and perhaps a new model/skin for the hero would be great. I'd need a modeler&texturer for the last part though (I can't make units on my own). But yes, I'll take care of the the SFXs. Right now fixing what Blu suggested. Moyack, yes, it existed, I made only a few minor tweaks before resubmitting (such as fixing the annoying Radiance bug). Right now still working on Radiance as apparently like Blu also pointed out, if you are given a health bonus item and you die, the spell gets messed up. It's easy to fix, but it needs a bit of math. And Blu, the ==false stuff ARE REQUIRED ya know. I need to compare (and contrast :P) "IsUnitType" with something if I want it to work. I hope you remember about the bug. Fixed the BJ stuff, Martyrism problem and working on fixing Radiance. However, I don't get the timers not getting destroyed problem. Could you please be more specific? Thanks! ~Daelin |
| 02-01-2007, 03:50 PM | #11 | |
Quote:
Yes I do know about the bug. I thought I remembered it not having to be done on every one of them, but apparently not. Well, if you look at the timer variables I mentioned, the timer they represent are not destroyed anywhere in the script (as far as I could see). |
| 02-01-2007, 04:50 PM | #12 |
That bug only applies in boolean expressions and if the IsUnitType() is the LAST comparison called. Otherwise, the == false is not required. |
| 02-02-2007, 12:04 PM | #13 |
Fixed all leaks (especially the timer stuff, indeed, I forgot to remove it in the expiration function). Now Radiance works perfectly with custom items that manipulate maximum life (or any other modifications of max HP that take place during the spell). Of course the bonuses received/lost are not doubled/halved. Have fun & hope to see it approved. ~Daelin |
| 02-03-2007, 02:00 AM | #14 | ||
Quote:
Quote:
Nicely done, Daelin; I enjoyed competing against you in the hero contest. I'm glad to see the other winners taking the initiative to upload their heroes like me /points at own hero thread |
| 02-03-2007, 02:46 PM | #15 |
I am so proud about the results of the current effects that I will actually make a new post and mention them. You will see that the map has a changelog (meaning that yes, I'm intensely updating it). By now, new effects for Martyrism, Blood Mana (buff) and Insidious Beacon have been added. They are all made by me, really small models (around 2-4 kb), and do not require any custom textures. Check the map periodically as I have other surprises waiting for you (after I finish the effects... though I'm stopping for today as I ran out of ideas). Have fun and don't forget to leave comments. It's good to know that the hero is actually tried and not only previewed (entering the thread). ~Daelin |
