Quick fix up

04-08-2007, 10:49 PM

I'm new to JASS and this trigger seems to error out and I can't figure out why. Also if you could help me with fixing anything up in it to make it go faster, it would be very helpful. I think it has something to do with the loop near the end, but I'm not whats wrong with the loop.

JASS:

function EndMultiboard takes nothing returns nothing

//Locals
local multiboard MB = null
local multiboarditem mbitem = null
local integer begin = 0
local integer end = 11

//Create Multiboard
    set MB = CreateMultiboard()
    call MultiboardSetRowCount(MB, 14)
    call MultiboardSetColumnCount(MB, 9)
    call MultiboardSetTitleText(MB, "End Score")
    call MultiboardDisplay(MB, true)

//Set Text In Rows and Columns
    call MultiboardSetItemWidthBJ( MB, 0, 0, 7.5)
    call MultiboardSetItemStyleBJ( MB, 0, 0, true, false )
// Columns
    set mbitem = MultiboardGetItem(MB, 0, 0)
    call MultiboardSetItemValue(mbitem, "Name")
    call MultiboardReleaseItem(mbitem)
    set mbitem = MultiboardGetItem(MB, 0, 1)
    call MultiboardSetItemValue(mbitem, "Freezes")
    call MultiboardReleaseItem(mbitem)
    set mbitem = MultiboardGetItem(MB, 0, 2)
    call MultiboardSetItemValue(mbitem, "Thaws")
    call MultiboardReleaseItem(mbitem)
    set mbitem = MultiboardGetItem(MB, 0, 3)
    call MultiboardSetItemValue(mbitem, "Total")
    call MultiboardReleaseItem(mbitem)
    set mbitem = MultiboardGetItem(MB, 0, 4)
    call MultiboardSetItemValue(mbitem, "Frozen")
    call MultiboardReleaseItem(mbitem)
    set mbitem = MultiboardGetItem(MB, 0, 5)
    call MultiboardSetItemValue(mbitem, "Thawed")
    call MultiboardReleaseItem(mbitem)
    set mbitem = MultiboardGetItem(MB, 0, 6)
    call MultiboardSetItemValue(mbitem, "Total")
    call MultiboardReleaseItem(mbitem)
    set mbitem = MultiboardGetItem(MB, 0, 7)
    call MultiboardSetItemValue(mbitem, "Ratio")
    call MultiboardReleaseItem(mbitem)
    set mbitem = MultiboardGetItem(MB, 0, 8)
    call MultiboardSetItemValue(mbitem, "Games")
    call MultiboardReleaseItem(mbitem)
//Rows
loop
    set mbitem = MultiboardGetItem(MB, begin, 0)
    call MultiboardSetItemValue(mbitem, ( udg_STRColors[begin+1] + GetPlayerName(ConvertedPlayer(begin)) ) )
    call MultiboardReleaseItem(mbitem)
    set begin = begin+1
exitwhen begin>end
endloop
    set mbitem = MultiboardGetItem(MB, 13, 0)
    call MultiboardSetItemValue(mbitem, "Time")
    call MultiboardReleaseItem(mbitem)
    call MultiboardDisplay(MB, true)
    call MultiboardMinimize(MB, false)
//Null Locals and End
set MB = null
set mbitem = null
endfunction

//Create Multiboard Trigger
function InitTrig_Multiboard_End takes nothing returns nothing
    set gg_trg_Multiboard_End = CreateTrigger(  )
    call TriggerRegisterTimerEventSingle( gg_trg_Multiboard_End, 5 )
    call TriggerAddAction( gg_trg_Multiboard_End, function EndMultiboard )
    set gg_trg_Multiboard_End = null
endfunction

04-09-2007, 07:47 PM	#2
Tastingo	Can someone help me instead of just looking, I've noticed this has 38 views and its been a day or 2. I'm pretty sure its something with the loop but I'm not sure what to do to fix it. I've also noticed that newer posts have been answered before this so sorry for double post.

04-09-2007, 08:33 PM	#3
Ammorth	JASS: call MultiboardSetItemValue(mbitem, ( udg_STRColors[begin+1] + GetPlayerName(ConvertedPlayer(begin)) ) ) should be JASS: call MultiboardSetItemValue(mbitem, ( udg_STRColors[begin+1] + GetPlayerName(Player(begin)) ) ) Player() starts at 0 where ConvertedPlayer() starts at 1.

04-09-2007, 10:57 PM	#4
Tastingo	Thank you for fixing this for me.

04-10-2007, 08:58 AM

blu_da_noob

Quote:

Originally Posted by Tastingo

Can someone help me instead of just looking, I've noticed this has 38 views and its been a day or 2.

To be more specific, it had been 9 hours. Don't bump your post after such a short time.