Expert trigger review & editing needed.

My Onslaught map needs a look at by someone more knowledgeable than me in the trigger and JASS department. I have built everything as best as I know how, avoiding leaks, etc. and lately cleaning up double free errors. However my game seems to be unfortunately unstable, in a vague general way. I have numerous problems that are impossible for me to test because they show up unpredictably and rarely (usually in games with many players). Such problems reported include:

• Being unable to move ones hero
• Being unable to use any abilities or items on a hero.
• Being unable to level up abilities on a hero.
• Power nodes being unable to be taken over.
• Fatal Errors (Access Violation)

As I said, these things only occur occasionally and with no apparent cause. Usually bugs like the first four will suddenly start manifesting together, leading me to believe that something or some things begin a systemic failure in the game. The last one has occurred out of the blue twice for me during a seemingly flawless game.

My map has a number of complex systems in it and I fear they are colliding in ways I can't understand. If anybody would dare to peruse the inner working of my map and advise me I would greatly appreciate it.

Does that sound like it's in GUI?

Say Moss, mind posting your map? So we can all see what's wrong.

Do you use I2H anywhere in your map?

Not H2I, turning a handle into an index is fine.
But turning an integer into a handle is horrible, it will cause major glitches like you describe eventually.

Systems guilty of using I2H include gamecache-based attaching systems like Handle Vars and CSCache.

You will need to replace anything that uses I2H with more modern methods such as structs.

You will check it with your 1 "|" JASS skills? :/

Sorry, I was taking a bit of a vacation from Warcraft I guess, thanks for the replies...


Are you serious that CSCache is really a problem? haven't millions of maps used CSCache since the beginning of time? Or at least since the beginning of CSCache. Do I really need to rewrite my whole map using these newfangled methods? That seems suspicious because the majority of maps out there have never used these crazy extended JASS systems including many complex, respected and stable maps. Maybe I2H has limitations but some use of them must be allowed.

Master_Of_GUI: The map uses a mix of GUI and jass.

I have this theory that if I avoid using temporary global variables and switch everything to jass and local variables instead then I could avoid potential runtime problems. But that is a lot of work and I don't know that it will actually fix anything and there are some situations where I don't see how I can avoid using temp globals.

Toink: I'd rather not release the code for my map to the general public. At least not any time soon. I would prefer to just PM the map to somebody on this forum, preferably with some reputation (they would have to be close to the level of Vex or Grim I think in order to be able to give me useful advice).

Then PM Vex then, why did you post a thread here asking for trigger review if you don't want anyone else to see it? We're not psychic you know :p

Well I have given the map to Vex before, for specific issues. But he is a busy guy and I don't expect him to do an in-depth analysis of my map. I don't need Vex himself, but someone who has good understanding standing of how certain practices may not cause immediate bugs but can potentially accumulate errors that eventually freak the game out in the ways I described. Such as this I2H thing apparently.