Unit slide and kill trigger. Need help plz

There is a spell to create the unit infront of the caster. Then with this trigger it slides away and kills a peon in my test. But when i keep casting it towards the peon and lots of 'UNITS' slide towards him, the LAST one kills him. Also it lags. Can some one please tell me what i should do?

I think your second Pick Every Unit actions should be embedded in the first. As it is now, the second loop will only use the last group as defined by the first loop, it won't use each group as it is created.

bad, dont embed Pick Every Unit, that will cause some stuff not to work as planned sometimes, but if you really feel like it, then try it yourself.

> bad, dont embed Pick Every Unit, that will cause some stuff not to work as planned sometimes, but if you really feel like it, then try it yourself.

Why would that happen? It certainly looks like that's what the code needs.

Here is my new trigger:

But it still gets very laggy. Do you see any leaks or anything wroug?

You need to destroy the second unit group inside the first unit group loop. Otherwise you only get rid of the last leak.

On an unrelated note, does anyone know why I can only post once every 10 minutes?

Like that? im testing it now...

still lags bad

I would destroy the group right after it's used, not before it is declared. Also, I don't think that every .01 seconds is any different from .03 seconds. I think the game only allows a minimum of something like .027 second intervals. If you still get lag, you might try increasing the interval.

Lastly, there's no need for the Do Nothing action. What's it going to do if you don't put it there? :P

@EvilMapCreator
Please don't double post, there is an edit key. Also do not bump your post unless it is more than two days old. Site policy.
@Ghan 04
You can't post more than 1/10 minutes to prevent spamming.

How many 'Water' units are there? Chances are that the lag is caused by the 'pick every unit in unit group' command going through an incredible amount of units.

If you only need to control one 'Water' unit, then as soon as you create it, set it to a variable and use the same commands (using (last created unit) to identify it), completely bypassing the 'pick every unit' command. I'm confused why you would set the 'Water' units to a unit group if you only have one.

For the command
the ((Matching unit) is alive) command is redundant if you are just doing damage.

It seems like you are trying to make the damage affect only enemies.
You can completely omit this statement if you replace your UnitGroup[2] variable to only include 'units matching(matching unit belongs to an enemy of (owner of picked unit))' This will consolidate the command.

As Ghan 04 said, the biggest lag factor is increasing the periodic time. There is a certain point where people simply cannot notice the difference between moving 2 feet every 0.01 seconds and 10 feet every 0.1 seconds. Try and find the highest interval that still gives a good effect.

Finally, yeah. Remove the 'do nothing' it is pointless.

> You can't post more than 1/10 minutes to prevent spamming.

Does that ever get lifted as I become more active?

Yep. I agree. You can limit the unit group to the units you want when it is defined, with no need of an If/Then/Else function. That should help your lag.

It's only for the first month after you join.

Do not use nested Group Loops! They will get fucked up when you refer to "picked unit" (in JASS: GetEnumUnit()) inside the second loop because the game won't know which picked unit to refer to.

However, if you do what you've done, evilmapcreater, and set the first Picked Unit to a variable before starting the loop, you should be fine.

> They will get fucked up when you refer to "picked unit"

> However, if you do what you've done, evilmapcreater, and set the first Picked Unit to a variable before starting the loop, you should be fine.

That's basically what I thought. I think it refers to the most recent picked unit, so if you want to use the other one, you have to store it.

> It's only for the first month after you join.

Hmph. What? Am I a spammer? Not like I'm new to WC3 or anything.... (I'm a mod on TH)

No, it's not singling you out; the post delay is active on all new members unless Vexorian or Tim. disables it for some amount of time.

It's to prevent massive spam attacks from people who register new accounts.

Try .04 instead of .01 it may not seem like alot, but it cuts the amount of calculations the computer has to do every second by 4 times.