ANOTHER Struct Question

I know you guys havent had enough of them from me so heres another one...

say you have a struct


is it necessary (preferable) to have an ondestroy method like


or does vJASS just recycle the space?

It will be recycled. I find onDestroy pointless cause its easy enough to clean them up before destroying the struct.

A onDestroy is good.

For example, if you know your gonna have an effect, a dummy unit and a lightning effect in your struct. Then use good practice and use the onDestroy method and clean up your effect, dummy and lightning.

or just clean it up.. saves you code space!

But isnt good practice. And if somebody reads over it (which they will most likely) it is always good to keep things clean. Bunching stuff up isnt good practice.
Its mildly acceptable in Jass as its slow, but onDestroy is definatly worth using in the case above.

I don't see how it's bunching stuff up, you're just nulling everything on the struct that's being destroyed. No need to read what's being done there, right?

Nulling? I'm destroying.
You dont null a variable in a struct thats pointing to an effect before destroying the effect.
You dont need to null structs at all, they get recycled, im talking about removing handles.

You're right, nulling wasn't the word I wanted to use. My point still stands though?

EDIT: nevermind this btw.. quite the worthless discussion :)

onDestroy is good if u need to destroy some struct that belongs to destroying struct.

unless, you destroy the struct on many different places, or you are making it to be used by other people and the contents of the struct might change later...

units(or handles in general) in a struct do not need to be nulled, as done above, correct?

i did not thing they did

however, things like effects or locations should be destroy/removed