PolledWait Crashing Game?

01-29-2008, 09:10 AM

JASS:

function Trig_Ice_Arrows_Effect_Conditions takes nothing returns boolean
    if ( not ( GetItemTypeId(UnitItemInSlotBJ(GetAttacker(), 1)) == 'I001' ) ) then
        return false
    endif
    return true
endfunction

function Trig_Ice_Arrows_Effect_Actions takes nothing returns nothing
    local unit slowward
    local location temp1 = GetUnitLoc(GetAttacker())
    local location temp2 = GetUnitLoc(GetAttackedUnitBJ())
    local real wait1 = DistanceBetweenPoints(temp1, temp2)
    call PolledWait( ( wait1 / 1200.00 ) )
    call CreateNUnitsAtLoc( 1, 'u001', GetOwningPlayer(GetAttacker()), temp2, bj_UNIT_FACING )
    set slowward = GetLastCreatedUnit()
    call SetUnitAbilityLevelSwapped( 'A008', slowward, GetItemCharges(UnitItemInSlotBJ(GetAttacker(), 1)) )
    
    call RemoveLocation(temp1)
    call RemoveLocation(temp2)
    
    call PolledWait( 4.00 )
    call KillUnit( slowward )
    call PolledWait( 0.5 )
    call RemoveUnit( slowward )
endfunction

//===========================================================================
function InitTrig_Ice_Arrows_Effect takes nothing returns nothing
    set gg_trg_Ice_Arrows_Effect = CreateTrigger(  )
    call TriggerRegisterAnyUnitEventBJ( gg_trg_Ice_Arrows_Effect, EVENT_PLAYER_UNIT_ATTACKED )
    call TriggerAddCondition( gg_trg_Ice_Arrows_Effect, Condition( function Trig_Ice_Arrows_Effect_Conditions ) )
    call TriggerAddAction( gg_trg_Ice_Arrows_Effect, function Trig_Ice_Arrows_Effect_Actions )
endfunction

After a few dozen calls of this spell the game crashes.(with either, PRIV_INSTRUCTION or 'the memory could not be written'. I'm not sure if that's useful information or not)

Commenting out

JASS:

    //call PolledWait( 4.00 )
    call KillUnit( slowward )
    //call PolledWait( 0.5 )
    call RemoveUnit( slowward )

Seems to fix the crash. I can make do without the waits here. But i need to know why they are crashing it as i'm going to need similar code elsewhere.
Any advice is appreciated.

01-29-2008, 10:57 AM	#2
cohadar	all waits sux balls, but PooledWait is a suckball world champion. Learn to use timers.

01-29-2008, 03:08 PM	#3
DioD	it may thread crush cos 3 w8s inside and last one w8 less then triggersleep limit allow.

01-29-2008, 03:53 PM	#4
Captain Griffen	Removing a unit that you don't know exists is bad. If it dies and then decays/something happens to it before you remove it, it could screw up.

01-29-2008, 04:09 PM	#5
PipeDream	Go to your Warcraft III\Errors folder and post a couple of the most recent Crash.txt files.

01-29-2008, 05:28 PM

Spectralist

Quote:

Originally Posted by Captain Griffen

Removing a unit that you don't know exists is bad. If it dies and then decays/something happens to it before you remove it, it could screw up.

It's caused crashes even while nothing effected by the ability dies. Although that's definitely something to keep in mind, it seems to crash much more often when i make the decay times real low and kill a bunch of units effected by this ability. So it's probable that that was contributing to the crashes, but theres at least one more crash inducing problem

Quote:

Originally Posted by PipeDream

Go to your Warcraft III\Errors folder and post a couple of the most recent Crash.txt files.

Hidden information:

01-29-2008, 05:38 PM	#7
Captain Griffen	It probably is the problem. Do this (a bit dirty, but should do the trick): JASS: call PolledWait( 4.00 ) if GetUnitTypeId( slowward ) != 0 then call KillUnit( slowward ) call PolledWait( 0.5 ) if GetUnitTypeId( slowward ) != 0 then call RemoveUnit( slowward ) endif endif

01-29-2008, 10:09 PM	#8
Toadcop	well anyway it's something "native" cause Code: The instruction at '0x001C0718' referenced memory at '0x593A5180'. The memory could not be 'written'.

01-30-2008, 01:53 AM	#9
PipeDream	oddly, not directly a JASS crash. presumably the bug griffen pointed out is smashing some blizzard structures.